8264333: Use the blessed modifier order in jdk.jshell

[alblue]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264333: Use the blessed modifier order in jdk.jshell

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3237/head:pull/3237
$ git checkout pull/3237

Update a local copy of the PR:
$ git checkout pull/3237
$ git pull https://git.openjdk.java.net/jdk pull/3237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3237

View PR using the GUI difftool:
$ git pr show -t 3237

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3237.diff

[bridgekeeper]

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alblue The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1213ba6)

[openjdk]

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264333: Use the blessed modifier order in jdk.jshell

Reviewed-by: iris, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• d2a63f2: 8264360: Loop strip mining verification fails with "should be on the backedge"
• 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
• bcdf469: 8264337: VM crashed when -XX:+VerifySharedSpaces
• 1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
• 182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
• 8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
• a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
• 128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
• fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
• f17ea9e: 8262899: TestRedirectLinks fails
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/a209ed01bafb7721d6b733d1c4bd3f1776463b5e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[alblue]

/integrate

[openjdk]

@alblue
Your change (at version 1213ba6) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

@shipilev @alblue Since your change was applied there have been 26 commits pushed to the master branch:

• d2a63f2: 8264360: Loop strip mining verification fails with "should be on the backedge"
• 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
• bcdf469: 8264337: VM crashed when -XX:+VerifySharedSpaces
• 1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
• 182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
• 8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
• a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
• 128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
• fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
• f17ea9e: 8262899: TestRedirectLinks fails
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/a209ed01bafb7721d6b733d1c4bd3f1776463b5e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8735259.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.