8253539: Remove unused JavaThread functions for set_last_Java_fp/pc

[coleenp]

These functions are also unused and in the thread_platform.hpp files. _last_Java_sp and _last_Java_fp are set in the assembly code for platforms that use these (x86, arm32 and aarch64). The shared runtime code never sets these, or should it. last_Java_fp() is always called through JavaFrameAnchor, so that function is not needed. last_Java_fp_offset() is used and needs to be in these platform dependent files because not all platforms save last_Java_fp.

Tested with build on arm32 and tier1 on Oracle platforms including aarch64.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253539: Remove unused JavaThread functions for set_last_Java_fp/pc

Reviewers

• Robbin Ehn (@robehn - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/324/head:pull/324
$ git checkout pull/324

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253539: Remove unused JavaThread functions for set_last_Java_fp/pc

Reviewed-by: rehn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• dd2c456: 8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697
• b1e2f02: 8253524: C2: Refactor code that clones predicates during loop unswitching
• c303fd5: 8253581: runtime/stringtable/StringTableCleaningTest.java fails on 32-bit platforms
• f3ea0d3: 8252583: Clean up unused phi-to-copy degradation mechanism
• 4440bda: 8219586: CodeHeap State Analytics processes dead nmethods
• 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
• ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
• 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
• f765a7f: 8252712: move doclint to jdk.javadoc module
• c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/b8ea80af33ecc9d4ccfa3c3dc366e1a88c3607b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (458a48b)

[dholmes-ora]

Seems okay.
Thanks.

[coleenp]

/integrate

[openjdk]

@coleenp Since your change was applied there have been 13 commits pushed to the master branch:

• dd2c456: 8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697
• b1e2f02: 8253524: C2: Refactor code that clones predicates during loop unswitching
• c303fd5: 8253581: runtime/stringtable/StringTableCleaningTest.java fails on 32-bit platforms
• f3ea0d3: 8252583: Clean up unused phi-to-copy degradation mechanism
• 4440bda: 8219586: CodeHeap State Analytics processes dead nmethods
• 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
• ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
• 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
• f765a7f: 8252712: move doclint to jdk.javadoc module
• c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/b8ea80af33ecc9d4ccfa3c3dc366e1a88c3607b4...master

Your commit was automatically rebased without conflicts.

Pushed as commit bf442c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.