8264027: Refactor "CLEANUP" region printing

[tschatzl]

Hi all,

can I have reviews for this small cleanup that refactors "CLEANUP" region status printing?

• where managing a FreeRegionList is not necessary, inline the call to the method (which is guarded by a check that if logging is not enabled, we do not print anything anyway)
• for the single remaining case, create a helper method in G1HRPrinter

The first item has been done as per the suggestion from @kstefanj here ; the alternative would be to keep the free region lists and call G1HRPrinter::cleanup on it later, which I actually initially implemented. I could not find a difference performance-wise.

Testing: checked if there is some perf difference on a heap with 50k regions; tier1-3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264027: Refactor "CLEANUP" region printing

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3243/head:pull/3243
$ git checkout pull/3243

Update a local copy of the PR:
$ git checkout pull/3243
$ git pull https://git.openjdk.java.net/jdk pull/3243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3243

View PR using the GUI difftool:
$ git pr show -t 3243

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3243.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ffb4c4c)

[kimbarrett]

Looks good.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264027: Refactor "CLEANUP" region printing

Reviewed-by: kbarrett, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 2c9365d: 8264271: Avoid creating non_oop_word oops
• daeca3f: 8262958: (fs) UnixUserDefinedFileAttributeView cleanup
• af02883: 8264191: Javadoc search is broken in Internet Explorer
• 6e74c3a: 8264193: Remove TRAPS parameters for modules and defaultmethods
• ee5e00b: 8264279: Shenandoah: Missing handshake after JDK-8263427
• ac604a1: 8264374: Shenandoah: Remove leftover parallel reference processing argument
• f3726a8: 8264020: Optimize double negation elimination
• 4ffa41c: 8263615: Cleanup tightly_coupled_allocation
• 4ea6abf: 8264324: Simplify allocation list management in OopStorage::reduce_deferred_updates
• 8735259: 8264333: Use the blessed modifier order in jdk.jshell
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/aefc1560b51f0ce96d8f5ce396ba0d2fe08fd650...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @kimbarrett @albertnetymk for your reviews.

/integrate

[openjdk]

@tschatzl Since your change was applied there have been 108 commits pushed to the master branch:

• eb6330e: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
• 8132548: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested
• ec7b002: 8264626: C1 should be able to inline excluded methods
• ff22353: 8264565: Templatize num_arguments() functions of DCmd subclasses
• 54b4070: 8264634: CollectCLDClosure collects duplicated CLDs when dumping dynamic archive
• 43d4a6f: 8264564: AArch64: use MOVI instead of FMOV to zero FP register
• dc608fd: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size
• b1a225e: 8263565: NPE was thrown when sun.jvm.hotspot.rmi.serverNamePrefix was set
• c41cd15: 8264686: ClhsdbTestConnectArgument.java should use SATestUtils::validateSADebugDPrivileges
• b7baca7: 8264288: Performance issue with MethodHandle.asCollector
• ... and 98 more: https://git.openjdk.java.net/jdk/compare/aefc1560b51f0ce96d8f5ce396ba0d2fe08fd650...master

Your commit was automatically rebased without conflicts.

Pushed as commit bf26a25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.