8264337: VM crashed when -XX:+VerifySharedSpaces #3244

kelthuzadx · 2021-03-29T15:27:55Z

java -XX:+VerifySharedSpaces -version reports an internal error that would crash VM:

[0.113s][error][cds] relocation bitmap CRC error
[0.114s][error][cds] relocation bitmap CRC error
# To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc: SuppressErrorAt=/javaClasses.inline.hpp:215
#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/home/qingfeng.yy/openjdk16_so_warning/jdk/src/hotspot/share/classfile/javaClasses.inline.hpp:215), pid=75241, tid=75242
# assert(java_lang_Class::is_instance(java_class)) failed: must be a Class object
#
# JRE version: (17.0) (slowdebug build )
# Java VM: OpenJDK 64-Bit Server VM (slowdebug 17-internal+0-adhoc.qingfengyy.jdk, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# V [libjvm.so+0x697d19] java_lang_Class::as_Klass(oopDesc*)+0x29
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/qingfeng.yy/openjdk16_so_warning/jdk/build/linux-x86_64-server-slowdebug/images/jdk/bin/hs_err_pid75241.log
#
#

The gut of this problem is that the calculation of crc32 for the CDS archive is inconsistent between dumptime and runtime, this will cause subsequent steps to deviate from the desired path one after another, eventually leading to an internal error that crashes the VM.

All tests under hotspot/jtreg/runtime/cds are passed(excepts those problem-listed) with slowdebug mode.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8264337: VM crashed when -XX:+VerifySharedSpaces

Reviewers

Yumin Qi (@yminqi - Reviewer) ⚠️ Review applies to 64780bc
Calvin Cheung (@calvinccheung - Reviewer) ⚠️ Review applies to 64780bc
Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3244/head:pull/3244
$ git checkout pull/3244

Update a local copy of the PR:
$ git checkout pull/3244
$ git pull https://git.openjdk.java.net/jdk pull/3244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3244

View PR using the GUI difftool:
$ git pr show -t 3244

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3244.diff

bridgekeeper · 2021-03-29T15:28:58Z

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-03-29T15:30:20Z

@kelthuzadx The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-03-29T15:33:44Z

Webrevs

yminqi

You are right. The crc is calculated based on used size, not aligned used size.

openjdk · 2021-03-29T17:43:07Z

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264337: VM crashed when -XX:+VerifySharedSpaces

Reviewed-by: minqi, ccheung, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
f17ea9e: 8262899: TestRedirectLinks fails
963f1fc: 8264309: JFR: Improve .jfc parser
364cce1: 8264332: Use the blessed modifier order in jdk.charsets
fbbd98b: 8264029: Replace uses of StringBuffer with StringBuilder in java.base
... and 9 more: https://git.openjdk.java.net/jdk/compare/99b4bab366fe897e41a35240e474ea0cb0b229d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yminqi, @calvinccheung, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

calvinccheung

LGTM.

kelthuzadx · 2021-03-30T01:55:04Z

Thanks @yminqi @calvinccheung for reviews！

/integrate

openjdk · 2021-03-30T01:55:41Z

@kelthuzadx
Your change (at version 64780bc) is now ready to be sponsored by a Committer.

shipilev

Minor nit.

shipilev · 2021-03-30T06:40:59Z

test/hotspot/jtreg/runtime/cds/appcds/VerifyWithDefaultArchive.java

+        out.shouldContain("OpenJDK");
+        out.shouldHaveExitValue(0);
+    }
+}


Please add the newline at the end of file here. See how UI complains about it :)

Got it. But I'm not sure what's the abbreviation UI means... Could you please give me a link for that? Thanks!

Thanks! I meant how GitHub UI (user interface) shows the red stop sign in cases like these.

kelthuzadx · 2021-03-30T07:01:17Z

/integrate

openjdk · 2021-03-30T07:02:15Z

@kelthuzadx
Your change (at version 0fe38b7) is now ready to be sponsored by a Committer.

shipilev · 2021-03-30T07:03:46Z

test/hotspot/jtreg/runtime/cds/appcds/VerifyWithDefaultArchive.java

+ */
+
+/*
+ * @test 8264337


Sorry, one other minor nit. This should be:

@test @bug 8264337

shipilev

Okay, we should be good to go. Thanks!

kelthuzadx · 2021-03-30T07:15:15Z

Thank you @shipilev, let me
/integrate
it again!

openjdk · 2021-03-30T07:15:52Z

@kelthuzadx
Your change (at version 2d863d7) is now ready to be sponsored by a Committer.

shipilev · 2021-03-30T07:18:59Z

I also ran runtime/cds tests without problem.

/sponsor

openjdk · 2021-03-30T07:20:37Z

@shipilev @kelthuzadx Since your change was applied there have been 19 commits pushed to the master branch:

1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
f17ea9e: 8262899: TestRedirectLinks fails
963f1fc: 8264309: JFR: Improve .jfc parser
364cce1: 8264332: Use the blessed modifier order in jdk.charsets
fbbd98b: 8264029: Replace uses of StringBuffer with StringBuilder in java.base
... and 9 more: https://git.openjdk.java.net/jdk/compare/99b4bab366fe897e41a35240e474ea0cb0b229d5...master

Your commit was automatically rebased without conflicts.

Pushed as commit bcdf469.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dholmes-ora · 2021-03-30T13:13:18Z

The test fails on a non-OpenJDK build as it explicitly checks for "OpenJDK". Filed JDK-8264429.

fix verify crash

64780bc

openjdk bot added the rfr label Mar 29, 2021

openjdk bot added the hotspot-runtime label Mar 29, 2021

yminqi approved these changes Mar 29, 2021

View changes

openjdk bot added the ready label Mar 29, 2021

calvinccheung approved these changes Mar 29, 2021

View changes

openjdk bot added the sponsor label Mar 30, 2021

shipilev approved these changes Mar 30, 2021

View changes

newline

0fe38b7

openjdk bot removed the sponsor label Mar 30, 2021

shipilev approved these changes Mar 30, 2021

View changes

openjdk bot added the sponsor label Mar 30, 2021

shipilev reviewed Mar 30, 2021

View changes

annotated @bug for bug-id

2d863d7

openjdk bot removed the sponsor label Mar 30, 2021

shipilev approved these changes Mar 30, 2021

View changes

openjdk bot added the sponsor label Mar 30, 2021

openjdk bot closed this Mar 30, 2021

openjdk bot added the integrated label Mar 30, 2021

openjdk bot removed sponsor ready rfr labels Mar 30, 2021

kelthuzadx deleted the fix_verifysharedspace_crash branch Mar 31, 2021

openjdk / jdk Public

8264337: VM crashed when -XX:+VerifySharedSpaces #3244

8264337: VM crashed when -XX:+VerifySharedSpaces #3244

kelthuzadx commented Mar 29, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Mar 29, 2021

openjdk bot commented Mar 29, 2021

mlbridge bot commented Mar 29, 2021 •

edited

yminqi left a comment

openjdk bot commented Mar 29, 2021 •

edited

calvinccheung left a comment

kelthuzadx commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

shipilev left a comment

shipilev Mar 30, 2021

kelthuzadx Mar 30, 2021

shipilev Mar 30, 2021

kelthuzadx commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

shipilev Mar 30, 2021

shipilev left a comment

kelthuzadx commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

shipilev commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

dholmes-ora commented Mar 30, 2021

openjdk / jdk Public

8264337: VM crashed when -XX:+VerifySharedSpaces #3244

8264337: VM crashed when -XX:+VerifySharedSpaces #3244

Conversation

kelthuzadx commented Mar 29, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 29, 2021

openjdk bot commented Mar 29, 2021

mlbridge bot commented Mar 29, 2021 • edited

Webrevs

yminqi left a comment

openjdk bot commented Mar 29, 2021 • edited

calvinccheung left a comment

kelthuzadx commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

shipilev left a comment

shipilev Mar 30, 2021

Choose a reason for hiding this comment

kelthuzadx Mar 30, 2021

Choose a reason for hiding this comment

shipilev Mar 30, 2021

Choose a reason for hiding this comment

kelthuzadx commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

shipilev Mar 30, 2021

Choose a reason for hiding this comment

shipilev left a comment

kelthuzadx commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

shipilev commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

dholmes-ora commented Mar 30, 2021

kelthuzadx commented Mar 29, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Mar 29, 2021 •

edited

openjdk bot commented Mar 29, 2021 •

edited