Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264360: Loop strip mining verification fails with "should be on the backedge" #3245

Closed
wants to merge 3 commits into from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Mar 29, 2021

The assert checks that loads that are found as uses of a loop back
edge have the back edge as control input. In this case, because that
code is executed during final graph reshaping (CastPPs are in the
process of being eliminated and memory operations inherit their
control inputs as precedence edges), the edge between a load and the
back edge is a precedence edge. Relaxing the assert is all that is
required.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264360: Loop strip mining verification fails with "should be on the backedge"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3245/head:pull/3245
$ git checkout pull/3245

Update a local copy of the PR:
$ git checkout pull/3245
$ git pull https://git.openjdk.java.net/jdk pull/3245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3245

View PR using the GUI difftool:
$ git pr show -t 3245

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3245.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2021

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2021
@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 29, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264360: Loop strip mining verification fails with "should be on the backedge"

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
  • bcdf469: 8264337: VM crashed when -XX:+VerifySharedSpaces
  • 1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
  • 182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
  • 8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
  • a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
  • 128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
  • fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
  • f17ea9e: 8262899: TestRedirectLinks fails
  • 963f1fc: 8264309: JFR: Improve .jfc parser
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/bc91596ca108ed366c35027cb01417d93543a1e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me but you might want to clean up the test a bit before pushing (I've added some comments).

public class TestLoadOnBackedgeWithPrec {
int c ;
a[] i = {
new a()};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespaces and newline should be removed.

new a()};
float j() {
a k = new a();
float l = 5 ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespaces before ; should be removed.

new a(), new a(), new a(),
new a(), new a(), new a(),
new a(), new a(), new a()};
c = i[0].g + k.g;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespaces before + should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this. I made the change you suggested.

@rwestrel
Copy link
Contributor Author

@vnkozlov @TobiHartmann Thanks for the reviews

@rwestrel
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Mar 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2021
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@rwestrel Since your change was applied there have been 78 commits pushed to the master branch:

  • 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
  • bcdf469: 8264337: VM crashed when -XX:+VerifySharedSpaces
  • 1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
  • 182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
  • 8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
  • a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
  • 128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
  • fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
  • f17ea9e: 8262899: TestRedirectLinks fails
  • 963f1fc: 8264309: JFR: Improve .jfc parser
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/bc91596ca108ed366c35027cb01417d93543a1e0...master

Your commit was automatically rebased without conflicts.

Pushed as commit d2a63f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants