Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248418: jpackage fails to extract main class and version from app module linked in external runtime #3249

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 29, 2021

Remove the test for failing jpackage use case scenario that we don't intent to fix


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248418: jpackage fails to extract main class and version from app module linked in external runtime

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3249/head:pull/3249
$ git checkout pull/3249

Update a local copy of the PR:
$ git checkout pull/3249
$ git pull https://git.openjdk.java.net/jdk pull/3249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3249

View PR using the GUI difftool:
$ git pr show -t 3249

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3249.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2021
@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 29, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248418: jpackage fails to extract main class and version from app module linked in external runtime

Reviewed-by: herrick, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • fd45694: 8264344: Outdated links in JavaComponentAccessibility.m

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2021
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2021
@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@alexeysemenyukoracle Since your change was applied there has been 1 commit pushed to the master branch:

  • fd45694: 8264344: Outdated links in JavaComponentAccessibility.m

Your commit was automatically rebased without conflicts.

Pushed as commit 128c0c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants