Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8219586: CodeHeap State Analytics processes dead nmethods #325

Closed
wants to merge 4 commits into from

Conversation

@RealLucy
Copy link
Contributor

@RealLucy RealLucy commented Sep 23, 2020

This change was already fully reviewed before the transition Mercurial to Git happened.
Reviewed-by: thartmann (TobiHartmann), eosterlund (Git name unknown)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8219586: CodeHeap State Analytics processes dead nmethods

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/325/head:pull/325
$ git checkout pull/325

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2020

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

⚠️ @RealLucy This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@RealLucy The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot label Sep 23, 2020
@RealLucy RealLucy marked this pull request as ready for review Sep 23, 2020
@openjdk openjdk bot added the rfr label Sep 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2020

Webrevs

@stefank
Copy link
Member

@stefank stefank commented Sep 23, 2020

CC @fisk

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Still looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@RealLucy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8219586: CodeHeap State Analytics processes dead nmethods

Reviewed-by: thartmann, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
  • ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
  • f765a7f: 8252712: move doclint to jdk.javadoc module
  • c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
  • 0bc01da: 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks
  • 812b39f: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary
  • 5f1d612: 8253397: Ensure LogTag types are sorted
  • b8ea80a: 8253457: Remove unimplemented register stack functions
  • e4d0e5a: 8253516: ZGC: Remove card table functions
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/0f26ab16ddf10cefc0b528aa12c7c2378a864063...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 24, 2020
fisk
fisk approved these changes Sep 24, 2020
Copy link
Contributor

@fisk fisk left a comment

Looks good.

@RealLucy
Copy link
Contributor Author

@RealLucy RealLucy commented Sep 24, 2020

Thank you, Tobias and Erik, for re-checking this fix.

@RealLucy
Copy link
Contributor Author

@RealLucy RealLucy commented Sep 24, 2020

/integrate

@openjdk openjdk bot closed this Sep 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@RealLucy Since your change was applied there have been 20 commits pushed to the master branch:

  • 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
  • ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
  • f765a7f: 8252712: move doclint to jdk.javadoc module
  • c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
  • 0bc01da: 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks
  • 812b39f: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary
  • 5f1d612: 8253397: Ensure LogTag types are sorted
  • b8ea80a: 8253457: Remove unimplemented register stack functions
  • e4d0e5a: 8253516: ZGC: Remove card table functions
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/0f26ab16ddf10cefc0b528aa12c7c2378a864063...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4440bda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants