8264396: Use the blessed modifier order in jdk.internal.jvmstat

[alblue]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264396: Use the blessed modifier order in jdk.internal.jvmstat

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Kevin Walls (@kevinjwalls - Committer) ⚠️ Review applies to 0583ebc
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3252/head:pull/3252
$ git checkout pull/3252

Update a local copy of the PR:
$ git checkout pull/3252
$ git pull https://git.openjdk.java.net/jdk pull/3252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3252

View PR using the GUI difftool:
$ git pr show -t 3252

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3252.diff

[bridgekeeper]

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alblue The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (244dac6f)
• 00: Full (0583ebc)

[plummercj]

The changes look fine, but you need to fix the CR number. It should be JDK-8264396. Also copyrights need updating.

[kevinjwalls]

Agreed, change looks good.

[shipilev]

Looks fine to me as well.

[openjdk]

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264396: Use the blessed modifier order in jdk.internal.jvmstat

Reviewed-by: cjplummer, kevinw, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 6225ae6: 8264466: Cut-paste error in InterfaceCalls JMH
• 40c3249: 8264149: BreakpointInfo::set allocates metaspace object in VM thread
• 999c134: 8264417: ParallelCompactData::region_offset should not accept pointers outside the current region
• 604b14c: 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java
• 9061271: 8261957: [PPC64] Support for Concurrent Thread-Stack Processing
• 8a4a911: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
• ab6faa6: 8263582: WB_IsMethodCompilable ignores compiler directives
• 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
• e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
• 815248a: 8264148: Update spec for exceptions retrofitted for exception chaining
• ... and 21 more: https://git.openjdk.java.net/jdk/compare/8cf1c62c345ce91208549294192944a1efe717cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @kevinjwalls, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[alblue]

Going to upstream this patch into opendjk/panama-foreign

[alblue]

Sorry, closed the wrong PR. This one should be good to go 🙄

[alblue]

/integrate

[openjdk]

@alblue
Your change (at version 244dac6) is now ready to be sponsored by a Committer.

[kevinjwalls]

/sponsor

[openjdk]

@kevinjwalls @alblue Since your change was applied there have been 31 commits pushed to the master branch:

• 6225ae6: 8264466: Cut-paste error in InterfaceCalls JMH
• 40c3249: 8264149: BreakpointInfo::set allocates metaspace object in VM thread
• 999c134: 8264417: ParallelCompactData::region_offset should not accept pointers outside the current region
• 604b14c: 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java
• 9061271: 8261957: [PPC64] Support for Concurrent Thread-Stack Processing
• 8a4a911: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
• ab6faa6: 8263582: WB_IsMethodCompilable ignores compiler directives
• 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
• e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
• 815248a: 8264148: Update spec for exceptions retrofitted for exception chaining
• ... and 21 more: https://git.openjdk.java.net/jdk/compare/8cf1c62c345ce91208549294192944a1efe717cf...master

Your commit was automatically rebased without conflicts.

Pushed as commit f43d14a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.