Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264396: Use the blessed modifier order in jdk.internal.jvmstat #3252

Closed
wants to merge 2 commits into from

Conversation

alblue
Copy link
Contributor

@alblue alblue commented Mar 29, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264396: Use the blessed modifier order in jdk.internal.jvmstat

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3252/head:pull/3252
$ git checkout pull/3252

Update a local copy of the PR:
$ git checkout pull/3252
$ git pull https://git.openjdk.java.net/jdk pull/3252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3252

View PR using the GUI difftool:
$ git pr show -t 3252

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3252.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2021

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@alblue The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org rfr Pull request is ready for review labels Mar 29, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2021

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, but you need to fix the CR number. It should be JDK-8264396. Also copyrights need updating.

Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, change looks good.

@alblue alblue changed the title 8263854: Use the blessed modifier in jdk.internal.jvmstat 8264396: Use the blessed modifier order in jdk.internal.jvmstat Mar 30, 2021
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as well.

@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264396: Use the blessed modifier order in jdk.internal.jvmstat

Reviewed-by: cjplummer, kevinw, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 6225ae6: 8264466: Cut-paste error in InterfaceCalls JMH
  • 40c3249: 8264149: BreakpointInfo::set allocates metaspace object in VM thread
  • 999c134: 8264417: ParallelCompactData::region_offset should not accept pointers outside the current region
  • 604b14c: 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java
  • 9061271: 8261957: [PPC64] Support for Concurrent Thread-Stack Processing
  • 8a4a911: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • ab6faa6: 8263582: WB_IsMethodCompilable ignores compiler directives
  • 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
  • e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
  • 815248a: 8264148: Update spec for exceptions retrofitted for exception chaining
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/8cf1c62c345ce91208549294192944a1efe717cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @kevinjwalls, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 31, 2021
@alblue
Copy link
Contributor Author

alblue commented Mar 31, 2021

Going to upstream this patch into opendjk/panama-foreign

@alblue alblue closed this Mar 31, 2021
@alblue
Copy link
Contributor Author

alblue commented Mar 31, 2021

Sorry, closed the wrong PR. This one should be good to go 🙄

@alblue alblue reopened this Mar 31, 2021
@alblue
Copy link
Contributor Author

alblue commented Mar 31, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@alblue
Your change (at version 244dac6) is now ready to be sponsored by a Committer.

@kevinjwalls
Copy link
Contributor

/sponsor

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@kevinjwalls @alblue Since your change was applied there have been 31 commits pushed to the master branch:

  • 6225ae6: 8264466: Cut-paste error in InterfaceCalls JMH
  • 40c3249: 8264149: BreakpointInfo::set allocates metaspace object in VM thread
  • 999c134: 8264417: ParallelCompactData::region_offset should not accept pointers outside the current region
  • 604b14c: 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java
  • 9061271: 8261957: [PPC64] Support for Concurrent Thread-Stack Processing
  • 8a4a911: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • ab6faa6: 8263582: WB_IsMethodCompilable ignores compiler directives
  • 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
  • e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
  • 815248a: 8264148: Update spec for exceptions retrofitted for exception chaining
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/8cf1c62c345ce91208549294192944a1efe717cf...master

Your commit was automatically rebased without conflicts.

Pushed as commit f43d14a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alblue alblue deleted the Sonar-InternlJVMStat branch March 31, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants