8264306: Non deterministic generation of java/lang/invoke/MemberName.class

[lahodaj]

When hoisting binding variables to the outer scope, we should use LinkedHashMap instead of HashMap, so that javac produces reproducible classfiles.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Joel Borggrén-Franck (@jbf - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3257/head:pull/3257
$ git checkout pull/3257

Update a local copy of the PR:
$ git checkout pull/3257
$ git pull https://git.openjdk.java.net/jdk pull/3257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3257

View PR using the GUI difftool:
$ git pr show -t 3257

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3257.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (22d6f5a)

[shipilev]

This makes sense to me (and it looks trivial).

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Reviewed-by: shade, jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 8735259: 8264333: Use the blessed modifier order in jdk.jshell
• d2a63f2: 8264360: Loop strip mining verification fails with "should be on the backedge"
• 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
• bcdf469: 8264337: VM crashed when -XX:+VerifySharedSpaces
• 1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
• 182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
• 8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
• a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
• 128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
• fd45694: 8264344: Outdated links in JavaComponentAccessibility.m
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/aefc1560b51f0ce96d8f5ce396ba0d2fe08fd650...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

@lahodaj Since your change was applied there have been 58 commits pushed to the master branch:

• 011f6d1: 8264223: CodeHeap::verify fails extra_hops assertion in fastdebug test
• 0696fd0: 8263496: MetalHighContrastTheme.getControlHighlight cleanup
• 6cf1095: 8264484: Replace uses of StringBuffer with StringBuilder in jdk.hotspot.agent
• d2df9a7: 8264331: Use the blessed modifier order in jdk.compiler
• 0228734: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
• 3997c99: 8264222: Use switch expression in jshell where possible
• 39f0b27: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total
• de495df: 8264413: Data is written to file header even if its CRC32 was calculated
• 52d8a22: 8264054: Bad XMM performance on java.lang.MathBench.sqrtDouble
• 16acfaf: 8012229: [lcms] Improve performance of color conversion for images with alpha channel
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/aefc1560b51f0ce96d8f5ce396ba0d2fe08fd650...master

Your commit was automatically rebased without conflicts.

Pushed as commit fdfa1dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.