8264417: ParallelCompactData::region_offset should not accept pointers outside the current region

[albertnetymk]

Change the accepted value range for ParallelCompactData::region_offset to avoid the surprising result, 0.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264417: ParallelCompactData::region_offset should not accept pointers outside the current region

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3260/head:pull/3260
$ git checkout pull/3260

Update a local copy of the PR:
$ git checkout pull/3260
$ git pull https://git.openjdk.java.net/jdk pull/3260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3260

View PR using the GUI difftool:
$ git pr show -t 3260

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3260.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f1cc1b4)

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264417: ParallelCompactData::region_offset should not accept pointers outside the current region

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 2c9365d: 8264271: Avoid creating non_oop_word oops
• daeca3f: 8262958: (fs) UnixUserDefinedFileAttributeView cleanup
• af02883: 8264191: Javadoc search is broken in Internet Explorer
• 6e74c3a: 8264193: Remove TRAPS parameters for modules and defaultmethods
• ee5e00b: 8264279: Shenandoah: Missing handshake after JDK-8263427
• ac604a1: 8264374: Shenandoah: Remove leftover parallel reference processing argument
• f3726a8: 8264020: Optimize double negation elimination
• 4ffa41c: 8263615: Cleanup tightly_coupled_allocation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

@albertnetymk Since your change was applied there have been 21 commits pushed to the master branch:

• 604b14c: 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java
• 9061271: 8261957: [PPC64] Support for Concurrent Thread-Stack Processing
• 8a4a911: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
• ab6faa6: 8263582: WB_IsMethodCompilable ignores compiler directives
• 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
• e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"
• 815248a: 8264148: Update spec for exceptions retrofitted for exception chaining
• 353807c: 8263898: (fs) Files.newOutputStream on the "NUL" special device throws FileSystemException: "nul: Incorrect function" (win)
• 2bd80f9: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation
• b08d638: 8262503: Support records in Dynalink
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/4ea6abfbd1818fa7049bc4f6e46d568e842acb34...master

Your commit was automatically rebased without conflicts.

Pushed as commit 999c134.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.