Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264277: java.xml.crypto module should be granted FilePermission and SocketPermission #3266

Closed
wants to merge 5 commits into from

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Mar 30, 2021

These permissions are needed so that the URIDereferencer is able to read data from a file system or a network. As the test shows, you still have to grant the same type of permission to your application.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264277: java.xml.crypto module should be granted FilePermission and SocketPermission

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3266/head:pull/3266
$ git checkout pull/3266

Update a local copy of the PR:
$ git checkout pull/3266
$ git pull https://git.openjdk.java.net/jdk pull/3266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3266

View PR using the GUI difftool:
$ git pr show -t 3266

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3266.diff

wangweij added 3 commits Mar 24, 2021
8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params
…SocketPermission

8264277: java.xml.crypto module should be granted FilePermission and SocketPermission
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 30, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into pr/3181 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2021

@wangweij The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 30, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Mar 30, 2021

/label remove core-libs

@openjdk openjdk bot removed the core-libs label Mar 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2021

@AlanBateman
The core-libs label was successfully removed.

@wangweij wangweij closed this Apr 2, 2021
@wangweij wangweij deleted the wangweij:8264277 branch Apr 2, 2021
@wangweij wangweij restored the wangweij:8264277 branch Apr 2, 2021
@wangweij wangweij reopened this Apr 2, 2021
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3181 to master Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@wangweij this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8264277
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
wangweij added 2 commits Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264277: java.xml.crypto module should be granted FilePermission and SocketPermission

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5303ccb: 8265135: Reduce work initializing VarForms
  • d9e40dd: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready and removed merge-conflict labels Apr 19, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Apr 19, 2021

/integrate

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@wangweij Since your change was applied there have been 2 commits pushed to the master branch:

  • 5303ccb: 8265135: Reduce work initializing VarForms
  • d9e40dd: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates

Your commit was automatically rebased without conflicts.

Pushed as commit 8bec6fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the wangweij:8264277 branch Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants