Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264466: Cut-paste error in InterfaceCalls JMH #3276

Closed
wants to merge 1 commit into from

Conversation

@ericcaspole
Copy link

@ericcaspole ericcaspole commented Mar 30, 2021

I think this typo may have always been there. There is a perf difference between 3 and 5 so it's worth fixing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3276/head:pull/3276
$ git checkout pull/3276

Update a local copy of the PR:
$ git checkout pull/3276
$ git pull https://git.openjdk.java.net/jdk pull/3276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3276

View PR using the GUI difftool:
$ git pr show -t 3276

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3276.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 30, 2021

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2021

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 30, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264466: Cut-paste error in InterfaceCalls JMH

Reviewed-by: shade, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
  • e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 31, 2021
@ericcaspole
Copy link
Author

@ericcaspole ericcaspole commented Mar 31, 2021

/integrate

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@ericcaspole Since your change was applied there have been 8 commits pushed to the master branch:

  • 40c3249: 8264149: BreakpointInfo::set allocates metaspace object in VM thread
  • 999c134: 8264417: ParallelCompactData::region_offset should not accept pointers outside the current region
  • 604b14c: 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java
  • 9061271: 8261957: [PPC64] Support for Concurrent Thread-Stack Processing
  • 8a4a911: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • ab6faa6: 8263582: WB_IsMethodCompilable ignores compiler directives
  • 928fa5b: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit
  • e073486: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"

Your commit was automatically rebased without conflicts.

Pushed as commit 6225ae6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ericcaspole ericcaspole deleted the ericcaspole:JDK-8264466 branch Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants