Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working #3286

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -104,6 +104,8 @@ private static void testMemoryFailCount(String value) throws Exception {
Common.logNewTestCase("testMemoryFailCount" + value);

// Check whether swapping really works for this test

This comment has been minimized.

@jerboaa

jerboaa Apr 6, 2021
Contributor

Please explain what "swapping not working" actually means in this comment. One version of it is already handled via JDK-8250984 so this is sort-of ambiguous. Suggestion: "On some systems there is no swap space enabled. On those systems running java -version??? with a memory limit fails due to swap space size being 0". Or something like that.

This comment has been minimized.

@DamonFool

DamonFool Apr 6, 2021
Author Member

Please explain what "swapping not working" actually means in this comment.

Updated.
Thanks.

// On some systems there is no swap space enabled. And running
// 'java -Xms{mem-limit} -Xmx{mem-limit} -version' would fail due to swap space size being 0.
DockerRunOptions preOpts =
new DockerRunOptions(imageName, "/jdk/bin/java", "-version");
preOpts.addDockerOpts("--volume", Utils.TEST_CLASSES + ":/test-classes/")
ProTip! Use n and p to navigate between commits in a pull request.