Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout #3287

Closed
wants to merge 2 commits into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Mar 31, 2021

Hi all,

I'd like to fix the timeout of javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
It seems to take about 6~7 seconds to run on some of our testing platforms.
But the timeout of the test is hard-coded as 5 seconds.

The fix just increases the timeout from 5 seconds to 10 seconds.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3287/head:pull/3287
$ git checkout pull/3287

Update a local copy of the PR:
$ git checkout pull/3287
$ git pull https://git.openjdk.java.net/jdk pull/3287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3287

View PR using the GUI difftool:
$ git pr show -t 3287

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3287.diff

@DamonFool
Copy link
Member Author

/issue add JDK-8264526
/label add swing
/cc swing

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@DamonFool
The swing label was successfully added.

@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@DamonFool The swing label was already applied.

@mlbridge
Copy link

mlbridge bot commented Mar 31, 2021

Webrevs

@azvegint
Copy link
Member

JDK-8078268 description says that it takes minutes to parse to complete before the fix. So 10 seconds is not a big deal comparing to minutes. However it might indicate a slight drop in performance.

It seems to take about 6~7 seconds to run on some of our testing platforms.

Did it fail on these platforms from the beginning of your testing with bug8078268?

@DamonFool
Copy link
Member Author

Did it fail on these platforms from the beginning of your testing with bug8078268?

No.

This week I add some testing infrastructure on dockers.
The timeout seems only to be observed on these dockers intermittently.
Thanks.

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 66d9961: 8205502: Make exception message from AnnotationInvocationHandler more informative
  • 5e59d28: 8262046: Clean up parallel class loading code and comments
  • 04f24fe: 8264403: [macos]: App names containing '.' characters results in an error message when launching
  • b953386: 8264609: Number.{byteValue, shortValue} spec should use @implSpec
  • 5858399: 8264285: Clean the modification of ccstr JVM flags
  • 6e0da99: 8263448: CTW: fatal error: meet not symmetric
  • 328e951: 8169629: Annotations with lambda expressions cause AnnotationFormatError
  • c04a743: 8264557: Incorrect copyright year for test/micro/org/openjdk/bench/java/lang/MathBench.java after JDK-8264054
  • 4b19771: 8264150: CDS dumping code calls TRAPS functions in VM thread
  • 1dc75e9: 8264538: Rename SystemDictionary::parse_stream
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/6225ae636e303a56d66449c895989f1ec46c6530...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2021
@DamonFool
Copy link
Member Author

Thanks @mrserb for your review.

@DamonFool
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@DamonFool Since your change was applied there have been 27 commits pushed to the master branch:

  • 66d9961: 8205502: Make exception message from AnnotationInvocationHandler more informative
  • 5e59d28: 8262046: Clean up parallel class loading code and comments
  • 04f24fe: 8264403: [macos]: App names containing '.' characters results in an error message when launching
  • b953386: 8264609: Number.{byteValue, shortValue} spec should use @implSpec
  • 5858399: 8264285: Clean the modification of ccstr JVM flags
  • 6e0da99: 8263448: CTW: fatal error: meet not symmetric
  • 328e951: 8169629: Annotations with lambda expressions cause AnnotationFormatError
  • c04a743: 8264557: Incorrect copyright year for test/micro/org/openjdk/bench/java/lang/MathBench.java after JDK-8264054
  • 4b19771: 8264150: CDS dumping code calls TRAPS functions in VM thread
  • 1dc75e9: 8264538: Rename SystemDictionary::parse_stream
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/6225ae636e303a56d66449c895989f1ec46c6530...master

Your commit was automatically rebased without conflicts.

Pushed as commit da643cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8264526 branch April 2, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
3 participants