New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8169629: Annotations with lambda expressions cause AnnotationFormatError #3294
Conversation
|
Webrevs
|
for(Method method : memberMethods) { | ||
currentMethod = method; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any use of currentMethod, am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remnant of a second fix I pulled out for separate handling; I'll remove before pushing. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the potentially unused var, looks good to me.
@jddarcy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@jddarcy Since your change was applied there have been 15 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 328e951. |
The stricter checks added by
8035781: Improve equality for annotations
in creating the proxy objects used to implement annotations has an unintended by-catch of rejecting annotation's whose type has, say, a field initialized with a lambda expression. While uncommon, it is legal code to have a field in an annotation type.
The updated checks skip over the sort of synthetic method used for the initialization.
Some different compilation tactics were used before and after nest mates, so the test includes compilation and testing under both situations.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3294/head:pull/3294
$ git checkout pull/3294
Update a local copy of the PR:
$ git checkout pull/3294
$ git pull https://git.openjdk.java.net/jdk pull/3294/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3294
View PR using the GUI difftool:
$ git pr show -t 3294
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3294.diff