Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264514: HexFormat implementation tweaks #3295

Closed
wants to merge 0 commits into from

Conversation

@rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Mar 31, 2021

Please review these small tweaks.

For background information see 1

Greetings
Raffaello


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3295/head:pull/3295
$ git checkout pull/3295

Update a local copy of the PR:
$ git checkout pull/3295
$ git pull https://git.openjdk.java.net/jdk pull/3295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3295

View PR using the GUI difftool:
$ git pr show -t 3295

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3295.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 31, 2021

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

⚠️ @rgiulietti a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 21e7402b04d835625521e7ba6f10c58cf708d276
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr label Mar 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Mar 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2021

Webrevs

@rgiulietti rgiulietti closed this Apr 7, 2021
@rgiulietti rgiulietti force-pushed the rgiulietti:master branch from 123f310 to 21e7402 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant