Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups #3297

Closed
wants to merge 1 commit into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Mar 31, 2021

Simplify ClassHierarchyWalker::is_witness().

Testing: hs-tier1 - hs-tier4.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3297/head:pull/3297
$ git checkout pull/3297

Update a local copy of the PR:
$ git checkout pull/3297
$ git pull https://git.openjdk.java.net/jdk pull/3297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3297

View PR using the GUI difftool:
$ git pr show -t 3297

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3297.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 31, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@iwanowww The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@iwanowww iwanowww marked this pull request as ready for review Mar 31, 2021
@openjdk openjdk bot added the rfr label Mar 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Looks like it has changes from: https://git.openjdk.java.net/jdk/pull/3293

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 1, 2021

I created it as a dependent PR.

I think that's the way it works (openjdk/skara#1087 which was used as an example in [1] looks similar).

[1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

Loading

@iwanowww iwanowww force-pushed the cha.1.is_witness branch from fc92da2 to b7f3132 Apr 1, 2021
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 1, 2021

Anyway, I rebased and force-pushed the patch since #3293 is integrated now.

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c04a743: 8264557: Incorrect copyright year for test/micro/org/openjdk/bench/java/lang/MathBench.java after JDK-8264054
  • 4b19771: 8264150: CDS dumping code calls TRAPS functions in VM thread
  • 1dc75e9: 8264538: Rename SystemDictionary::parse_stream

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 1, 2021
@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Apr 1, 2021

I created it as a dependent PR.

I think that's the way it works (openjdk/skara#1087 which was used as an example in [1] looks similar).

[1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

As I understand when you are creating PR which based on an other PR you have to change base: from master to corresponding pr/3293 so that only difference of current PR are seen.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 2, 2021

Thanks, Vladimir.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 2, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@iwanowww Since your change was applied there have been 16 commits pushed to the master branch:

  • 177bc84: 8264606: More comment for ECDH public key validation
  • 885916e: 8262280: Incorrect exception handling for VMThread in class redefinition
  • 7d0a0ba: 8264109: Add vectorized implementation for VectorMask.andNot()
  • 0935eaa: 8264409: AArch64: generate better code for Vector API allTrue
  • 4793557: 8264502: (fc) FileDispatcherImpl.setDirect0 might return uninitialized variable on some platforms
  • da643cd: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout
  • 66d9961: 8205502: Make exception message from AnnotationInvocationHandler more informative
  • 5e59d28: 8262046: Clean up parallel class loading code and comments
  • 04f24fe: 8264403: [macos]: App names containing '.' characters results in an error message when launching
  • b953386: 8264609: Number.{byteValue, shortValue} spec should use @implSpec
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/80681b547090d4ab2b43662312e63a6a210c070b...master

Your commit was automatically rebased without conflicts.

Pushed as commit f60e81b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants