Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test #33

Closed
wants to merge 1 commit into from

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Sep 6, 2020

pre-Skara RFR thread

Hi all,

could you please review this small and trivial cleanup?

from JBS:

compiler/c2/stemmer test uses jdk.test.lib.FileInstaller to copy "words" file from the test source directory to the current working directory, compiler.c2.stemmer.Stemmer can read this file. yet, c.c.s.Stemmer class treats its 1st argument as a path to the file, given this isn't needed and we can pass "${test.src}/words" instead of "words"

testing: compiler/c2/stemmer on {linux,windows,macos}-x64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/33/head:pull/33
$ git checkout pull/33

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 6, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@iignatev The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@iignatev
Copy link
Member Author

@iignatev iignatev commented Sep 6, 2020

/reviewer add epavlova

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@iignatev
Reviewer epavlova successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@iignatev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test

Reviewed-by: shade, epavlova
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 37 commits pushed to the master branch:

  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
  • f933961: 8252980: comment only changes extracted from JDK-8247281
  • 4333942: 8250217: com.sun.tools.javac.api.JavacTaskImpl swallows compiler exceptions potentially producing false positive test results
  • 5166094: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 6329de4: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • d560964: 8252794: Creation of JNIMethodBlock should be done with a leaf lock
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/5f76deb2e064ca8a48fb8a638c23aad34bf27f9c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 8db333531fabbe95461c00c2ba26191ce39442cd.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 6, 2020

Webrevs

Loading

@openjdk openjdk bot added the ready label Sep 10, 2020
@iignatev
Copy link
Member Author

@iignatev iignatev commented Sep 10, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2020

@iignatev Since your change was applied there have been 37 commits pushed to the master branch:

  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
  • f933961: 8252980: comment only changes extracted from JDK-8247281
  • 4333942: 8250217: com.sun.tools.javac.api.JavacTaskImpl swallows compiler exceptions potentially producing false positive test results
  • 5166094: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 6329de4: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • d560964: 8252794: Creation of JNIMethodBlock should be done with a leaf lock
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/5f76deb2e064ca8a48fb8a638c23aad34bf27f9c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5b30a83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@iignatev iignatev deleted the 8252778 branch Sep 11, 2020
cushon pushed a commit to cushon/jdk that referenced this issue Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants