Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258788: incorrect response to change in window insets [lanai] #3308

Closed
wants to merge 1 commit into from

Conversation

avu
Copy link
Contributor

@avu avu commented Apr 1, 2021

Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. MTLLayer.h header cleanup.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258788: incorrect response to change in window insets [lanai]

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3308/head:pull/3308
$ git checkout pull/3308

Update a local copy of the PR:
$ git checkout pull/3308
$ git pull https://git.openjdk.java.net/jdk pull/3308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3308

View PR using the GUI difftool:
$ git pr show -t 3308

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3308.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2021

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2021

⚠️ @avu a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 80681b547090d4ab2b43662312e63a6a210c070b
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2021
@openjdk
Copy link

openjdk bot commented Apr 1, 2021

@avu The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org labels Apr 1, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Apr 1, 2021

Is it possible to automatically test it?

@avu
Copy link
Contributor Author

avu commented Apr 2, 2021

Is it possible to automatically test it?

Yes, just added the test.

@jayathirthrao
Copy link
Member

jayathirthrao commented Apr 6, 2021

Is it possible to automatically test it?

Yes, just added the test.

@avu Test passes without fix also.

@jayathirthrao
Copy link
Member

jayathirthrao commented Apr 6, 2021

Verified test case attached in JBS : https://bugs.openjdk.java.net/browse/JDK-8258788 . I see that fix resolves identified issue in JBS. Also jtreg and JCK test run is green with and without Metal API validation flags.

@avu
Copy link
Contributor Author

avu commented Apr 6, 2021

@avu Test passes without fix also.
@jayathirthrao Could you provide the details about your configuration along with parameters passed to jtreg ?

@jayathirthrao
Copy link
Member

jayathirthrao commented Apr 6, 2021

@avu Test passes without fix also.
@jayathirthrao Could you provide the details about your configuration along with parameters passed to jtreg ?

@avu I am running test in 13 inch Macbook Early 2015 with integrated Intel Iris Graphics 6100.
jtreg command i am using "jtreg -jdk:<path_to_jdk> -Dsun.java2d.metal=true <path_to_test>"

@jayathirthrao
Copy link
Member

jayathirthrao commented Apr 6, 2021

Is it possible to automatically test it?

Yes, just added the test.

@avu Test passes without fix also.

@aghaisas Please verify the regression test behavior from your end also.

@avu
Copy link
Contributor Author

avu commented Apr 7, 2021

@avu I am running test in 13 inch Macbook Early 2015 with integrated Intel Iris Graphics 6100.
jtreg command i am using "jtreg -jdk:<path_to_jdk> -Dsun.java2d.metal=true <path_to_test>"
@jayathirthrao I'm not sure that -Dsun.java2d.metal had been passed to the test JVM. I rechecked with slightly different command line and the test fails without the fix
jtreg -ignore:quiet -v -a -xml -vmoptions:"-Dsun.java2d.metal=True " -testjdk:path_to_jdk path_to_test

Perform replaceSurfaceData on insets change
@avu
Copy link
Contributor Author

avu commented Apr 8, 2021

I've created a simpler solution within another pull request. Please, have a look https://git.openjdk.java.net/jdk/pull/3390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org rfr Pull request is ready for review
4 participants