Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment #3309

Closed
wants to merge 3 commits into from

Conversation

@yminqi
Copy link
Contributor

@yminqi yminqi commented Apr 1, 2021

Hi, Please review
After JDK-8236847, the shared region alignment (new as MetaspaceShared::core_region_alignment) is no longer default to os pagesize, it is a configurable value at build time instead. The WhiteBox api metaspaceReserveAlignment() should reflect the change.

Tests:tier1,tier2,tier3,tier4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3309/head:pull/3309
$ git checkout pull/3309

Update a local copy of the PR:
$ git checkout pull/3309
$ git pull https://git.openjdk.java.net/jdk pull/3309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3309

View PR using the GUI difftool:
$ git pr show -t 3309

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3309.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 1, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2021

@yminqi The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Apr 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 1, 2021

Webrevs

Yumin Qi Yumin Qi
Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good. Just one comment in one of the test changes.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment

Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 104e925: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding
  • a0ec2cb: 8248862: Implement Enhanced Pseudo-Random Number Generators
  • 39719da: 8253266: JList and JTable constructors should clear OPAQUE_SET before calling updateUI
  • a8005ef: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
  • 7f9ece2: 8264650: Cross-compilation to macos/aarch64
  • 0039c18: 8264475: CopyArea ignores clip state in metal rendering pipeline
  • f084bd2: 8262355: Support for AVX-512 opmask register allocation.
  • 0780666: 8254050: HotSpot Style Guide should permit using the "override" virtual specifier
  • f259eea: 8264393: JDK-8258284 introduced dangling TLH race
  • 9b2232b: 8264123: add ThreadsList.is_valid() support
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/c04a743bd43946ee88862be83f205a7bdcb6d0f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 2, 2021
@iklam
iklam approved these changes Apr 5, 2021
@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Apr 5, 2021

@calvinccheung @iklam Thanks for review!

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Apr 5, 2021

/integrate

@openjdk openjdk bot closed this Apr 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@yminqi Since your change was applied there have been 33 commits pushed to the master branch:

  • 104e925: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding
  • a0ec2cb: 8248862: Implement Enhanced Pseudo-Random Number Generators
  • 39719da: 8253266: JList and JTable constructors should clear OPAQUE_SET before calling updateUI
  • a8005ef: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
  • 7f9ece2: 8264650: Cross-compilation to macos/aarch64
  • 0039c18: 8264475: CopyArea ignores clip state in metal rendering pipeline
  • f084bd2: 8262355: Support for AVX-512 opmask register allocation.
  • 0780666: 8254050: HotSpot Style Guide should permit using the "override" virtual specifier
  • f259eea: 8264393: JDK-8258284 introduced dangling TLH race
  • 9b2232b: 8264123: add ThreadsList.is_valid() support
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/c04a743bd43946ee88862be83f205a7bdcb6d0f4...master

Your commit was automatically rebased without conflicts.

Pushed as commit d920f85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yminqi yminqi deleted the yminqi:jdk-8264540 branch Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants