8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697

[shipilev]

JDK-8246697 added -Xmx4g to test configurations. 32-bit VMs cannot do it. @requires tests the OS RAM size, but you can easily have the x86_32 host with more than 4G ram, yet JVM would fail to acquire that heap size. Need to check for bitness explicitly.

Testing:

• java/util/StringJoiner on x86_64 (still run)
• java/util/StringJoiner on x86_32 (skipped now)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/331/head:pull/331
$ git checkout pull/331

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (fbba21b)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253583: java/util/StringJoiner tests failing on 32-bit VMs after JDK-8246697

Reviewed-by: alanb, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• b1e2f02: 8253524: C2: Refactor code that clones predicates during loop unswitching
• c303fd5: 8253581: runtime/stringtable/StringTableCleaningTest.java fails on 32-bit platforms
• f3ea0d3: 8252583: Clean up unused phi-to-copy degradation mechanism
• 4440bda: 8219586: CodeHeap State Analytics processes dead nmethods
• 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
• ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
• 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
• f765a7f: 8252712: move doclint to jdk.javadoc module
• c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
• 0bc01da: 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/8c02bdbf13bc8258bbdb6c45fd3b3ba4c6f8971b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Lgtm.

[shipilev]

Trivial, right?

[tschatzl]

Trivial.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 28 commits pushed to the master branch:

• b1e2f02: 8253524: C2: Refactor code that clones predicates during loop unswitching
• c303fd5: 8253581: runtime/stringtable/StringTableCleaningTest.java fails on 32-bit platforms
• f3ea0d3: 8252583: Clean up unused phi-to-copy degradation mechanism
• 4440bda: 8219586: CodeHeap State Analytics processes dead nmethods
• 154b8cf: 8253014: OopStorage bulk release logs entries multiple times
• ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
• 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
• f765a7f: 8252712: move doclint to jdk.javadoc module
• c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
• 0bc01da: 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/8c02bdbf13bc8258bbdb6c45fd3b3ba4c6f8971b...master

Your commit was automatically rebased without conflicts.

Pushed as commit dd2c456.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.