Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8205502: Make exception message from AnnotationInvocationHandler more informative #3317

Closed
wants to merge 2 commits into from

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 1, 2021

Simple change to make the exception/error messages more informative for various malformed annotation situations.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8205502: Make exception message from AnnotationInvocationHandler more informative

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3317/head:pull/3317
$ git checkout pull/3317

Update a local copy of the PR:
$ git checkout pull/3317
$ git pull https://git.openjdk.java.net/jdk pull/3317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3317

View PR using the GUI difftool:
$ git pr show -t 3317

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3317.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 1, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 1, 2021
@openjdk openjdk bot added the rfr label Apr 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 1, 2021

Webrevs

@bplb
bplb approved these changes Apr 1, 2021
Copy link
Member

@bplb bplb left a comment

Looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8205502: Make exception message from AnnotationInvocationHandler more informative

Reviewed-by: bpb, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 1, 2021
@naotoj
naotoj approved these changes Apr 1, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Apr 1, 2021

/integrate

@openjdk openjdk bot closed this Apr 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2021

@jddarcy Pushed as commit 66d9961.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the jddarcy:8205502 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants