8253572: [windows] CDS archive may fail to open with long file names

[tstuefe]

Hi all,

there is a long standing bug in the windows version of os::pd_map_memory() which may cause it to fail if the path to the underlying file is longer than the OS limit. This is mainly of interest for CDS, which uses this functionality to map in sections of the archive into the memory. This bug may cause the CDS mapping to fail. See also https://bugs.openjdk.java.net/browse/JDK-8249943.

As with similar cases, the fix is to translate the input file name to a wide character UNC path name and use the Unicode variant of CreateFile which accepts long path names.

/issue add 8253572, 8249943
/test tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8253572: [windows] CDS archive may fail to open with long file names
• JDK-8249943: [TESTBUG] runtime/cds/serviceability/transformRelatedClasses/TransformInterfaceAndImplementor.java

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/332/head:pull/332
$ git checkout pull/332

[tstuefe]

/test tier1

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe you need to get approval to run the tests in tier1 for commits up until e2140d8

[openjdk]

@tstuefe This issue is referenced in the PR title - it will now be updated.

Adding additional issue to issue list: 8249943: [TESTBUG] runtime/cds/serviceability/transformRelatedClasses/TransformInterfaceAndImplementor.java.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (e2140d8)

[calvinccheung]

Thanks for identifying the bug and fixing it. The patch looks good.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253572: [windows] CDS archive may fail to open with long file names
8249943: [TESTBUG] runtime/cds/serviceability/transformRelatedClasses/TransformInterfaceAndImplementor.java


Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 4167540: 8253647: Remove dead code in os::create_thread() on Linux/BSD
• 5a57945: 8231591: [TESTBUG] Create additional two phase jpackage tests
• b159e4e: 8253149: Building an installer from invalid app image fails on Window…
• 0e855fe: 8252377: Incorrect encoding for EC AlgorithmIdentifier
• 9150b90: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64
• 0187567: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 …
• a75edc2: 8251188: Update LDAP tests not to use wildcard addresses
• 1f5a033: 8253555: Make ByteSize and WordSize typed scoped enums
• f62eefc: 8253469: ARM32 Zero: replace usages of __sync_synchronize() with OrderAccess::fence
• 1b79326: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/f3ea0d362f7ec33cf2a446236214f56f0816a0e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Thanks for identifying the bug and fixing it. The patch looks good.

Thank you Calvin!

[tstuefe]

/test build
/test tier1

[tstuefe]

Ping... may I have a second review please?

[iklam]

LGTM

[tstuefe]

LGTM

Thanks Ioi!

[tstuefe]

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 29 commits pushed to the master branch:

• 4167540: 8253647: Remove dead code in os::create_thread() on Linux/BSD
• 5a57945: 8231591: [TESTBUG] Create additional two phase jpackage tests
• b159e4e: 8253149: Building an installer from invalid app image fails on Window…
• 0e855fe: 8252377: Incorrect encoding for EC AlgorithmIdentifier
• 9150b90: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64
• 0187567: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 …
• a75edc2: 8251188: Update LDAP tests not to use wildcard addresses
• 1f5a033: 8253555: Make ByteSize and WordSize typed scoped enums
• f62eefc: 8253469: ARM32 Zero: replace usages of __sync_synchronize() with OrderAccess::fence
• 1b79326: 8242451: ensure semantics of non-capturing lambdas are preserved independent of execution mode
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/f3ea0d362f7ec33cf2a446236214f56f0816a0e0...master

Your commit was automatically rebased without conflicts.

Pushed as commit b66fa8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.