Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1 #3324

Closed
wants to merge 2 commits into from

Conversation

@DougLea
Copy link
Contributor

@DougLea DougLea commented Apr 2, 2021

This reinserts setting common pool parallelism inadvertently clobbered in JDK-8259800


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3324/head:pull/3324
$ git checkout pull/3324

Update a local copy of the PR:
$ git checkout pull/3324
$ git pull https://git.openjdk.java.net/jdk pull/3324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3324

View PR using the GUI difftool:
$ git pr show -t 3324

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3324.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 2, 2021

👋 Welcome back dl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@DougLea The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 2, 2021
@DougLea DougLea changed the title Jdk 8264572 JDK-8264572 reinsert common pool parallelism assignment Apr 2, 2021
@openjdk openjdk bot added the rfr label Apr 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

This looks okay to me, I just wonder if we should have a test to the value of getCommonPoolParallelism.

@DougLea
Copy link
Contributor Author

@DougLea DougLea commented Apr 2, 2021

We once had a test, but now that Runtime.availableProcessors (the only means of checking) can return varying values, we can't include in tck tests. The error here wasn't caught because we didn't run the usual performance tests (that catch these problems immediately) because I was focused only on JDK-8259800. Sorry.

@DougLea
Copy link
Contributor Author

@DougLea DougLea commented Apr 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@DougLea This PR has not yet been marked as ready for integration.

@DougLea DougLea changed the title JDK-8264572 reinsert common pool parallelism assignment JDK-8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1 Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@DougLea This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 9c283da: 8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC
  • eb0ac86: 8264655: Minor internal doc comment cleanup
  • 3991b32: 8264539: Improve failure message of java/nio/file/WatchService/SensitivityModifier.java
  • 4133ded: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64
  • 220ddbd: 8264657: ProblemList java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java on linux-x64
  • d0f3cc9: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64
  • 6c145c4: 8264544: Case-insensitive comparison issue with supplementary characters.
  • f60e81b: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups
  • 177bc84: 8264606: More comment for ECDH public key validation
  • 885916e: 8262280: Incorrect exception handling for VMThread in class redefinition
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/5858399062543cc5300b18971d5c4c2639118fc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 2, 2021
@DougLea
Copy link
Contributor Author

@DougLea DougLea commented Apr 2, 2021

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@DougLea Since your change was applied there have been 18 commits pushed to the master branch:

  • 9c283da: 8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC
  • eb0ac86: 8264655: Minor internal doc comment cleanup
  • 3991b32: 8264539: Improve failure message of java/nio/file/WatchService/SensitivityModifier.java
  • 4133ded: 8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64
  • 220ddbd: 8264657: ProblemList java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java on linux-x64
  • d0f3cc9: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64
  • 6c145c4: 8264544: Case-insensitive comparison issue with supplementary characters.
  • f60e81b: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups
  • 177bc84: 8264606: More comment for ECDH public key validation
  • 885916e: 8262280: Incorrect exception handling for VMThread in class redefinition
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/5858399062543cc5300b18971d5c4c2639118fc8...master

Your commit was automatically rebased without conflicts.

Pushed as commit cec66cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants