New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264650: Cross-compilation to macos/aarch64 #3325
Conversation
|
@AntonKozlov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
make/autoconf/flags.m4
Outdated
@@ -265,6 +265,11 @@ AC_DEFUN_ONCE([FLAGS_PRE_TOOLCHAIN], | |||
fi | |||
fi | |||
|
|||
if test "x$OPENJDK_TARGET_OS" = xmacosx && | |||
test "x$OPENJDK_TARGET_CPU" = xaarch64; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting on this!
For symmetry, and to enable cross compilation on both directions, can we add the necessary flag for x64 too?
Also, I doubt it matters much, but we could also only set these flags if COMPILE_TYPE=cross.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking again, it doesn't hurt to be explicit about this. Better always set these flags to avoid surprises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I haven't thought it is possible, although clearly it should be :) Thanks! Fixed by always setting the flag. I also rely on Github Action to check this with Xcode 11.3.1, it seems to be fine https://github.com/AntonKozlov/jdk/runs/2256008843
@AntonKozlov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.
|
/integrate |
@AntonKozlov |
/sponsor |
@VladimirKempik @AntonKozlov Since your change was applied there have been 16 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7f9ece2. |
Please review adding necessary flags for cross-compilation on macos/x86 targeting macos/aarch64.
All CFLAGS, CXXFLAGS, LDFLAGS need target CPU flag
-arch arm64
.This patch adds the flag along e.g
-m64
.Tested:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3325/head:pull/3325
$ git checkout pull/3325
Update a local copy of the PR:
$ git checkout pull/3325
$ git pull https://git.openjdk.java.net/jdk pull/3325/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3325
View PR using the GUI difftool:
$ git pr show -t 3325
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3325.diff