New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8264655: Minor internal doc comment cleanup #3327
Conversation
|
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
* @author Bhavesh Patel | ||
* @author Jonathan Gibbons (revised) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file was moved here from the jdk.compiler
module, where we have not removed the @author
comments.
@jonathan-gibbons This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@jonathan-gibbons Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit eb0ac86. |
Please review some minor updates to internal doc comments on javadoc code.
In addition, since this is just a cleanup PR, some redundant modifiers noted by an IDE have been removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3327/head:pull/3327
$ git checkout pull/3327
Update a local copy of the PR:
$ git checkout pull/3327
$ git pull https://git.openjdk.java.net/jdk pull/3327/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3327
View PR using the GUI difftool:
$ git pr show -t 3327
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3327.diff