Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64 #3330

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 2, 2021

A trivial fix to ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3330/head:pull/3330
$ git checkout pull/3330

Update a local copy of the PR:
$ git checkout pull/3330
$ git pull https://git.openjdk.java.net/jdk pull/3330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3330

View PR using the GUI difftool:
$ git pr show -t 3330

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3330.diff

@dcubed-ojdk
Copy link
Member Author

/label add swing

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk dcubed-ojdk changed the base branch from master to pr/3329 April 2, 2021 18:44
@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review April 2, 2021 18:44
@openjdk openjdk bot added rfr Pull request is ready for review swing client-libs-dev@openjdk.org labels Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@dcubed-ojdk
The swing label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 2, 2021

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3329 to master April 2, 2021 18:52
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264658: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on linux-x64

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2021
@dcubed-ojdk
Copy link
Member Author

@pankaj-bansal - Thanks for the fast review.

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@dcubed-ojdk Pushed as commit 4133ded.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8264658 branch April 2, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants