Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC #3331

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 2, 2021

A trivial fix to ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java
on win-x64 with ZGC


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3331/head:pull/3331
$ git checkout pull/3331

Update a local copy of the PR:
$ git checkout pull/3331
$ git pull https://git.openjdk.java.net/jdk pull/3331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3331

View PR using the GUI difftool:
$ git pr show -t 3331

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3331.diff

…locking001/AdaptiveBlocking001.java on win-x64 with ZGC
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 2, 2021

/label add hotspot-compiler
/label add hotspot-gc

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 2, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 2, 2021
@openjdk openjdk bot added the hotspot-gc label Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@dcubed-ojdk
The hotspot-gc label was successfully added.

Loading

@openjdk openjdk bot added the rfr label Apr 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2021

Webrevs

Loading

hseigel
hseigel approved these changes Apr 2, 2021
Copy link
Member

@hseigel hseigel left a comment

Looks good and trivial.
Thanks, Harold

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • eb0ac86: 8264655: Minor internal doc comment cleanup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 2, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 2, 2021

@hseigel - Thanks for the review!

/integrate

Loading

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • eb0ac86: 8264655: Minor internal doc comment cleanup

Your commit was automatically rebased without conflicts.

Pushed as commit 9c283da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8264662 branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants