Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8264664: use text blocks in javac module tests #3335

Closed

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Apr 3, 2021

Please review an update to the javac module tests to use text blocks to represent multi-line strings.

The conversion was done mostly semi-automatically, using a utility used to covert the javadoc tests. Some edits were manual.

In all cases, there are no changes to the semantics of any test. In particular, no diagnostic messages containing line and column information were updated.

All :tier1 tests pass on all standard platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3335/head:pull/3335
$ git checkout pull/3335

Update a local copy of the PR:
$ git checkout pull/3335
$ git pull https://git.openjdk.java.net/jdk pull/3335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3335

View PR using the GUI difftool:
$ git pr show -t 3335

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3335.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 3, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 3, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Apr 3, 2021
@jddarcy
jddarcy approved these changes Apr 3, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Apr 3, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 3, 2021

@jonathan-gibbons Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@openjdk
Copy link

@openjdk openjdk bot commented Apr 3, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264664: use text blocks in javac module tests

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • cec66cf: 8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1
  • 9c283da: 8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Apr 3, 2021

/integrate

@openjdk openjdk bot closed this Apr 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 3, 2021

@jonathan-gibbons Since your change was applied there have been 2 commits pushed to the master branch:

  • cec66cf: 8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1
  • 9c283da: 8264662: ProblemList vmTestbase/jit/escape/AdaptiveBlocking/AdaptiveBlocking001/AdaptiveBlocking001.java on win-x64 with ZGC

Your commit was automatically rebased without conflicts.

Pushed as commit e8eda65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 3, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants