8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB #3336

huishi-hs · 2021-04-03T00:53:54Z

Please help review this fix. Detailed analysis in https://bugs.openjdk.java.net/browse/JDK-8264649

Tier1/2 release /fastdebug passed

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB

Reviewers

Tobias Hartmann (@TobiHartmann - Reviewer)
Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3336/head:pull/3336
$ git checkout pull/3336

Update a local copy of the PR:
$ git checkout pull/3336
$ git pull https://git.openjdk.java.net/jdk pull/3336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3336

View PR using the GUI difftool:
$ git pr show -t 3336

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3336.diff

…tdebug C2 with -XX:-UseTLAB

bridgekeeper · 2021-04-03T00:54:34Z

👋 Welcome back hshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-03T00:57:58Z

@huishi-hs The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-03T01:01:59Z

Webrevs

01: Full - Incremental (2f6b68df)
00: Full (08292fe1)

huishi-hs · 2021-04-03T01:02:12Z

/label add hotspot-compiler

openjdk · 2021-04-03T01:02:59Z

@huishi-hs
The hotspot-compiler label was successfully added.

TobiHartmann · 2021-04-07T11:27:47Z

test/hotspot/jtreg/runtime/InternalApi/ThreadCpuTimesDeadlock.java

+/*
+ * @test
+ * @bug 8264649
+ * @summary OSR compiled metthod crash when UseTLAB is off


Typo metthod.

TobiHartmann · 2021-04-07T11:29:06Z

src/hotspot/share/opto/phaseX.cpp

@@ -1481,6 +1481,9 @@ void PhaseIterGVN::subsume_node( Node *old, Node *nn ) {
  temp->init_req(0,nn);     // Add a use to nn to prevent him from dying


Just wondering, why do we even need this? Without that code, remove_dead_node(old) would kill nn as well if it becomes dead.

Thanks for your review!

Checking code history, this code is quite old. From comments around, it doesn't want nn removed directly in PhaseIterGVN::subsume_node and leaves optimization to next GVN iteration.

In my understanding, it might save callers to insert codes checking if "nn" is removed/dead at every subsume_node/replace_node callsite, simplifies implementation.

8153779 hotspot/src/share/vm/opto/phaseX.cpp (J. Duke 2007-12-01 00:00:00 +0000 1479) // Smash all inputs to 'old', isolating him completely
2a0815a hotspot/src/share/vm/opto/phaseX.cpp (Tobias Hartmann 2014-06-02 08:07:29 +0200 1480) Node *temp = new Node(1);
8153779 hotspot/src/share/vm/opto/phaseX.cpp (J. Duke 2007-12-01 00:00:00 +0000 1481) temp->init_req(0,nn); // Add a use to nn to prevent him from dying
8153779 hotspot/src/share/vm/opto/phaseX.cpp (J. Duke 2007-12-01 00:00:00 +0000 1482) remove_dead_node( old );
8153779 hotspot/src/share/vm/opto/phaseX.cpp (J. Duke 2007-12-01 00:00:00 +0000 1483) temp->del_req(0); // Yank bogus edge

Note nn could be new node created during parsing which does not have users yet. that is why we need to keep it

TobiHartmann

Thanks for the details. Your fix looks reasonable to me.

openjdk · 2021-04-09T07:02:24Z

@huishi-hs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB

Reviewed-by: thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

76bd313: 8264872: Dependencies: Migrate to PerfData counters
07c8ff4: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp
863feab: 8005295: Use mandated information for printing of repeating annotations
f26cd2a: 8264997: Remove SystemDictionary::cache_get
9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report
cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
06e6b1f: 8259242: Remove ProtectionDomainSet_lock
... and 89 more: https://git.openjdk.java.net/jdk/compare/66d9961cbd83dbfca20b0af3c20693438d4aff3f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

vnkozlov

I agree with change.

huishi-hs · 2021-04-09T23:56:14Z

Thanks! @TobiHartmann @vnkozlov

huishi-hs · 2021-04-09T23:56:36Z

/integrate

openjdk · 2021-04-09T23:57:16Z

@huishi-hs
Your change (at version 2f6b68d) is now ready to be sponsored by a Committer.

DamonFool · 2021-04-10T00:03:15Z

/sponsor

openjdk · 2021-04-10T00:04:31Z

@DamonFool @huishi-hs Since your change was applied there have been 99 commits pushed to the master branch:

76bd313: 8264872: Dependencies: Migrate to PerfData counters
07c8ff4: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp
863feab: 8005295: Use mandated information for printing of repeating annotations
f26cd2a: 8264997: Remove SystemDictionary::cache_get
9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report
cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
06e6b1f: 8259242: Remove ProtectionDomainSet_lock
... and 89 more: https://git.openjdk.java.net/jdk/compare/66d9961cbd83dbfca20b0af3c20693438d4aff3f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 42f4d70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fas…

08292fe

…tdebug C2 with -XX:-UseTLAB

openjdk bot added the rfr Pull request is ready for review label Apr 3, 2021

openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 3, 2021

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 3, 2021

TobiHartmann suggested changes Apr 7, 2021

View reviewed changes

fix typo in test description

2f6b68d

TobiHartmann approved these changes Apr 9, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 9, 2021

vnkozlov approved these changes Apr 9, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 9, 2021

openjdk bot closed this Apr 10, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2021

huishi-hs deleted the 8264649 branch April 30, 2021 09:53

dafedafe mentioned this pull request Jan 23, 2023

JDK-8298118: split-if optimization causes empty loop to temporarily have more than one phi #12148

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB #3336

8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB #3336

huishi-hs commented Apr 3, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 3, 2021

openjdk bot commented Apr 3, 2021

mlbridge bot commented Apr 3, 2021 •

edited

Loading

huishi-hs commented Apr 3, 2021

openjdk bot commented Apr 3, 2021

TobiHartmann Apr 7, 2021

huishi-hs Apr 7, 2021

TobiHartmann Apr 7, 2021

huishi-hs Apr 7, 2021 •

edited

Loading

vnkozlov Apr 9, 2021

TobiHartmann left a comment

openjdk bot commented Apr 9, 2021 •

edited

Loading

vnkozlov left a comment

huishi-hs commented Apr 9, 2021

huishi-hs commented Apr 9, 2021

openjdk bot commented Apr 9, 2021

DamonFool commented Apr 10, 2021

openjdk bot commented Apr 10, 2021

		@@ -1481,6 +1481,9 @@ void PhaseIterGVN::subsume_node( Node old, Node nn ) {
		temp->init_req(0,nn); // Add a use to nn to prevent him from dying

8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB #3336

8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB #3336

Conversation

huishi-hs commented Apr 3, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Apr 3, 2021

openjdk bot commented Apr 3, 2021

mlbridge bot commented Apr 3, 2021 • edited Loading

Webrevs

huishi-hs commented Apr 3, 2021

openjdk bot commented Apr 3, 2021

TobiHartmann Apr 7, 2021

Choose a reason for hiding this comment

huishi-hs Apr 7, 2021

Choose a reason for hiding this comment

TobiHartmann Apr 7, 2021

Choose a reason for hiding this comment

huishi-hs Apr 7, 2021 • edited Loading

Choose a reason for hiding this comment

vnkozlov Apr 9, 2021

Choose a reason for hiding this comment

TobiHartmann left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 9, 2021 • edited Loading

vnkozlov left a comment

Choose a reason for hiding this comment

huishi-hs commented Apr 9, 2021

huishi-hs commented Apr 9, 2021

openjdk bot commented Apr 9, 2021

DamonFool commented Apr 10, 2021

openjdk bot commented Apr 10, 2021

huishi-hs commented Apr 3, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 3, 2021 •

edited

Loading

huishi-hs Apr 7, 2021 •

edited

Loading

openjdk bot commented Apr 9, 2021 •

edited

Loading