Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264680: Use the blessed modifier order in java.desktop #3337

Closed
wants to merge 2 commits into from

Conversation

alblue
Copy link
Contributor

@alblue alblue commented Apr 3, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264680: Use the blessed modifier order in java.desktop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3337/head:pull/3337
$ git checkout pull/3337

Update a local copy of the PR:
$ git checkout pull/3337
$ git pull https://git.openjdk.java.net/jdk pull/3337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3337

View PR using the GUI difftool:
$ git pr show -t 3337

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3337.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2021

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2021

@alblue The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • sound
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org swing client-libs-dev@openjdk.org sound client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org rfr Pull request is ready for review labels Apr 3, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2021

Webrevs

mrserb
mrserb approved these changes Apr 4, 2021
@openjdk
Copy link

openjdk bot commented Apr 4, 2021

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264680: Use the blessed modifier order in java.desktop

Reviewed-by: serb, kizune, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 114e3c3: 8263856: Github Actions for macos/aarch64 cross-build
  • a611c46: 8264048: Fix caching in Jar URL connections when an entry is missing
  • bf26a25: 8264027: Refactor "CLEANUP" region printing
  • eb6330e: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
  • 8132548: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested
  • ec7b002: 8264626: C1 should be able to inline excluded methods
  • ff22353: 8264565: Templatize num_arguments() functions of DCmd subclasses
  • 54b4070: 8264634: CollectCLDClosure collects duplicated CLDs when dumping dynamic archive
  • 43d4a6f: 8264564: AArch64: use MOVI instead of FMOV to zero FP register
  • dc608fd: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/f259eeaf65cbbd360e96f8c102653feb636eb899...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @azuev-java, @azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2021
@alblue
Copy link
Contributor Author

alblue commented Apr 4, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2021
@openjdk
Copy link

openjdk bot commented Apr 4, 2021

@alblue
Your change (at version 7bb8d9d) is now ready to be sponsored by a Committer.

@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

@azvegint azvegint Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year in other files might be updated as well.

@mrserb
Copy link
Member

mrserb commented Apr 7, 2021

/sponsor

@openjdk openjdk bot closed this Apr 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@mrserb @alblue Since your change was applied there have been 31 commits pushed to the master branch:

  • 17202c8: 8264748: Do not include arguments.hpp from compilerDefinitions.hpp
  • c3abdc9: 8264797: Do not include klassVtable.hpp from instanceKlass.hpp
  • eb5c097: 8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present
  • bfb034a: 8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working
  • a756d8d: 8264759: x86_32 Minimal VM build failure after JDK-8262355
  • 0f13e22: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"
  • 4bb80f3: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out
  • 2f51699: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias
  • 114e3c3: 8263856: Github Actions for macos/aarch64 cross-build
  • a611c46: 8264048: Fix caching in Jar URL connections when an entry is missing
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/f259eeaf65cbbd360e96f8c102653feb636eb899...master

Your commit was automatically rebased without conflicts.

Pushed as commit 92fad1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alblue alblue deleted the Cleanup-JavaDesktop branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org integrated Pull request has been integrated sound client-libs-dev@openjdk.org swing client-libs-dev@openjdk.org
4 participants