Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264686: ClhsdbTestConnectArgument.java should use SATestUtils::validateSADebugDPrivileges #3339

Closed
wants to merge 1 commit into from

Conversation

@YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Apr 5, 2021

JDK-8263670 has introduced SATestUtils::validateSADebugDPrivileges to check privileges for on OS X.

/**
* This tests has issues if you try adding privileges on OSX. The debugd process cannot
* be killed if you do this (because it is a root process and the test is not), so the destroy()
* call fails to do anything, and then waitFor() will time out. If you try to manually kill it with
* a "sudo kill" command, that seems to work, but then leaves the LingeredApp it was
* attached to in a stuck state for some unknown reason, causing the stopApp() call
* to timeout. For that reason we don't run this test when privileges are needed. Note
* it does appear to run fine as root, so we still allow it to run on OSX when privileges
* are not required.
*/
public static void validateSADebugDPrivileges() {
if (needsPrivileges()) {
throw new SkippedException("Cannot run this test on OSX if adding privileges is required.");
}
}

Most of testcases in serviceability/sa/sadebugd use it, however ClhsdbTestConnectArgument.java isn't so yet.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264686: ClhsdbTestConnectArgument.java should use SATestUtils::validateSADebugDPrivileges

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3339/head:pull/3339
$ git checkout pull/3339

Update a local copy of the PR:
$ git checkout pull/3339
$ git pull https://git.openjdk.java.net/jdk pull/3339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3339

View PR using the GUI difftool:
$ git pr show -t 3339

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3339.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 5, 2021

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@YaSuenag The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@YaSuenag YaSuenag marked this pull request as ready for review Apr 5, 2021
@openjdk openjdk bot added the rfr label Apr 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 5, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264686: ClhsdbTestConnectArgument.java should use SATestUtils::validateSADebugDPrivileges

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • b7baca7: 8264288: Performance issue with MethodHandle.asCollector
  • 9201899: 8264729: Random check-in failing header checks.
  • d920f85: 8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment
  • 104e925: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding
  • a0ec2cb: 8248862: Implement Enhanced Pseudo-Random Number Generators
  • 39719da: 8253266: JList and JTable constructors should clear OPAQUE_SET before calling updateUI
  • a8005ef: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
  • 7f9ece2: 8264650: Cross-compilation to macos/aarch64
  • 0039c18: 8264475: CopyArea ignores clip state in metal rendering pipeline

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 5, 2021
@YaSuenag
Copy link
Member Author

@YaSuenag YaSuenag commented Apr 5, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@YaSuenag Since your change was applied there have been 9 commits pushed to the master branch:

  • b7baca7: 8264288: Performance issue with MethodHandle.asCollector
  • 9201899: 8264729: Random check-in failing header checks.
  • d920f85: 8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment
  • 104e925: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding
  • a0ec2cb: 8248862: Implement Enhanced Pseudo-Random Number Generators
  • 39719da: 8253266: JList and JTable constructors should clear OPAQUE_SET before calling updateUI
  • a8005ef: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
  • 7f9ece2: 8264650: Cross-compilation to macos/aarch64
  • 0039c18: 8264475: CopyArea ignores clip state in metal rendering pipeline

Your commit was automatically rebased without conflicts.

Pushed as commit c41cd15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@YaSuenag YaSuenag deleted the JDK-8264686 branch Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants