Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264729: Random check-in failing header checks. #3343

Closed
wants to merge 4 commits into from

Conversation

@JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Apr 5, 2021

open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3343/head:pull/3343
$ git checkout pull/3343

Update a local copy of the PR:
$ git checkout pull/3343
$ git pull https://git.openjdk.java.net/jdk pull/3343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3343

View PR using the GUI difftool:
$ git pr show -t 3343

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3343.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 5, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@JimLaskey To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing
@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Apr 5, 2021

/label core-libs

@openjdk openjdk bot added the core-libs label Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@JimLaskey
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 5, 2021

@erikj79
erikj79 approved these changes Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264729: Random check-in failing header checks.

Reviewed-by: erikj, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d920f85: 8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment
  • 104e925: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 5, 2021
@bplb
bplb approved these changes Apr 5, 2021
@openjdk openjdk bot removed the ready label Apr 5, 2021
@JimLaskey JimLaskey changed the title 8264729: Orphan file - shouldn't be in sources. 8264729: Random check-in failing header checks. Apr 5, 2021
@openjdk openjdk bot added the ready label Apr 5, 2021
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2020 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.

This comment has been minimized.

@erikj79

erikj79 Apr 5, 2021
Member

Shouldn't this be:
2012, 2021,

This comment has been minimized.

@JimLaskey

JimLaskey Apr 5, 2021
Author Member

The earlier dates were while under development. As far as I know, this is the first time they appear. But I can change if that is the consensus.

@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Apr 5, 2021

/integrate

@openjdk openjdk bot closed this Apr 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@JimLaskey Since your change was applied there have been 2 commits pushed to the master branch:

  • d920f85: 8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment
  • 104e925: 8264512: jdk/test/jdk/java/util/prefs/ExportNode.java relies on default platform encoding

Your commit was automatically rebased without conflicts.

Pushed as commit 9201899.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants