8264752: JFR crash when only specify threadbuffersize=30M #3355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGFPE crash happens in release build with following JFR crash options. Because div_total_by_per_unit try to divide smaller memorysize with larger threadbuffersize.
-XX:StartFlightRecording -XX:FlightRecorderOptions:threadbuffersize=30M
-XX:StartFlightRecording -XX:FlightRecorderOptions:threadbuffersize=30M,memorysize=10M
Fix includes
There are other assertions in debug build with JFR options, leave them in other bug fix (https://bugs.openjdk.java.net/browse/JDK-8241773)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3355/head:pull/3355
$ git checkout pull/3355
Update a local copy of the PR:
$ git checkout pull/3355
$ git pull https://git.openjdk.java.net/jdk pull/3355/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3355
View PR using the GUI difftool:
$ git pr show -t 3355
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3355.diff