8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

[Michael-Mc-Mahon]

Hi,

Could I get the following small test fix reviewed please? The test is timing out on Mac probably because it is running on a system with a proxy that is not bypassed for loopback connections. The test already sets NO_PROXY explicitly for one part of the test. It needs to do the equivalent for the second part.

Thanks,
Michael

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3358/head:pull/3358
$ git checkout pull/3358

Update a local copy of the PR:
$ git checkout pull/3358
$ git pull https://git.openjdk.java.net/jdk pull/3358/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3358

View PR using the GUI difftool:
$ git pr show -t 3358

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3358.diff

[bridgekeeper]

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Michael-Mc-Mahon The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (88fda213)

[dfuch]

LGTM

[openjdk]

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Michael-Mc-Mahon]

/integrate

[openjdk]

@Michael-Mc-Mahon Since your change was applied there has been 1 commit pushed to the master branch:

• 2f51699: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias

Your commit was automatically rebased without conflicts.

Pushed as commit 4bb80f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.