Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" #3359

Closed
wants to merge 3 commits into from

Conversation

@JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Apr 6, 2021

SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3359/head:pull/3359
$ git checkout pull/3359

Update a local copy of the PR:
$ git checkout pull/3359
$ git pull https://git.openjdk.java.net/jdk pull/3359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3359

View PR using the GUI difftool:
$ git pr show -t 3359

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3359.diff

…y.SecureRandom nextFloat consecutive"
@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Apr 6, 2021

/label core-libs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 6, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@JimLaskey
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 6, 2021

Webrevs

@jddarcy
jddarcy approved these changes Apr 6, 2021
@@ -439,7 +439,10 @@ public static void main(String[] args) {
RandomGeneratorFactory.all().forEach(factory -> {
setRNG(factory.name());

if (factory.name().equals("Random")) {
if (currentRNG.equals("SecureRandom")) {
// Bug: 8264791

This comment has been minimized.

@jddarcy

jddarcy Apr 6, 2021
Member

It is generally not necessary to include bug ids in the text of changesets.

This comment has been minimized.

@dcubed-ojdk

dcubed-ojdk Apr 6, 2021
Member

Should you add an "@bug 8264791" in the header instead?

@@ -439,7 +439,10 @@ public static void main(String[] args) {
RandomGeneratorFactory.all().forEach(factory -> {
setRNG(factory.name());

if (factory.name().equals("Random")) {

This comment has been minimized.

@jddarcy

jddarcy Apr 6, 2021
Member

A string-switch on the currentRNG name might be better structured here.

@bplb
bplb approved these changes Apr 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

Reviewed-by: darcy, bpb, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4bb80f3: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 6, 2021
@@ -439,7 +439,10 @@ public static void main(String[] args) {
RandomGeneratorFactory.all().forEach(factory -> {
setRNG(factory.name());

if (factory.name().equals("Random")) {
if (currentRNG.equals("SecureRandom")) {
// Bug: 8264791

This comment has been minimized.

@dcubed-ojdk

dcubed-ojdk Apr 6, 2021
Member

Should you add an "@bug 8264791" in the header instead?

@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Apr 6, 2021

/integrate

@openjdk openjdk bot closed this Apr 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@JimLaskey Since your change was applied there has been 1 commit pushed to the master branch:

  • 4bb80f3: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Your commit was automatically rebased without conflicts.

Pushed as commit 0f13e22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants