Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr #3367

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Apr 7, 2021

Hi all,

test-lib fails to build due to three javac warnings:

/jdk/test/lib/jdk/test/lib/hexdump/ASN1Formatter.java:250: warning: [fallthrough] possible fall-through into case
                case TAG_PrintableString:
                ^
error: warnings found and -Werror specified
/jdk/test/lib/jdk/test/lib/jfr/GCHelper.java:336: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
                        openGcIds.push(new Integer(gcId));
                                       ^
/jdk/test/lib/jdk/test/lib/jfr/SimpleEventHelper.java:80: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            missingIds.remove(new Integer(id));

It would be better to fix it.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3367/head:pull/3367
$ git checkout pull/3367

Update a local copy of the PR:
$ git checkout pull/3367
$ git pull https://git.openjdk.java.net/jdk pull/3367/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3367

View PR using the GUI difftool:
$ git pr show -t 3367

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3367.diff

@DamonFool
Copy link
Member Author

/label add core-libs
/label add hotspot-jfr
/cc core-libs
/cc hotspot-jfr

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@DamonFool
The core-libs label was successfully added.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@DamonFool
The hotspot-jfr label was successfully added.

@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@DamonFool The core-libs label was already applied.

@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@DamonFool The hotspot-jfr label was already applied.

@mlbridge
Copy link

mlbridge bot commented Apr 7, 2021

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
It seems only the build-test-lib make rule has error on warnings set.
When running the tests, the compiles do not fail. (though the warnings are produced).

@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • eab8455: 8261137: Optimization of Box nodes in uncommon_trap
  • 92fad1b: 8264680: Use the blessed modifier order in java.desktop
  • 17202c8: 8264748: Do not include arguments.hpp from compilerDefinitions.hpp
  • c3abdc9: 8264797: Do not include klassVtable.hpp from instanceKlass.hpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2021
@DamonFool
Copy link
Member Author

Thanks @RogerRiggs .
/integrate

@openjdk openjdk bot closed this Apr 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2021
@openjdk
Copy link

openjdk bot commented Apr 8, 2021

@DamonFool Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 88eb291.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8264809 branch April 8, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants