New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264143 Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1 #3368
Conversation
Check num of work items in compute shader.
|
@dekonoplyov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Add stdint include to fix x64 build
LGTM.
Ran RenderPerfTest in my Intel Integrated SoC there are no issues.
CI test run of jtreg and JCK tests is fine.
Basic sanity with J2DDemo and Swingset2 is also fine.
@dekonoplyov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 158 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao) but any other Committer may sponsor as well.
|
/integrate |
@dekonoplyov |
/sponsor |
@jayathirthrao @dekonoplyov Since your change was applied there have been 165 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 926e3bc. |
There was no code to check num of work items in compute shader.
Also, I've replaced four similar shaders.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3368/head:pull/3368
$ git checkout pull/3368
Update a local copy of the PR:
$ git checkout pull/3368
$ git pull https://git.openjdk.java.net/jdk pull/3368/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3368
View PR using the GUI difftool:
$ git pr show -t 3368
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3368.diff