Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264143 Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1 #3368

Closed
wants to merge 3 commits into from

Conversation

dekonoplyov
Copy link

@dekonoplyov dekonoplyov commented Apr 7, 2021

There was no code to check num of work items in compute shader.
Also, I've replaced four similar shaders.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3368/head:pull/3368
$ git checkout pull/3368

Update a local copy of the PR:
$ git checkout pull/3368
$ git pull https://git.openjdk.java.net/jdk pull/3368/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3368

View PR using the GUI difftool:
$ git pr show -t 3368

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3368.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back dkonoplev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@dekonoplyov The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

Copy link
Member

@jayathirthrao jayathirthrao left a comment

LGTM.
Ran RenderPerfTest in my Intel Integrated SoC there are no issues.
CI test run of jtreg and JCK tests is fine.
Basic sanity with J2DDemo and Swingset2 is also fine.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dekonoplyov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 158 new commits pushed to the master branch:

  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • 79adc16: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 1c3fd46: 8265175: (fs) Files.copy(Path,Path,CopyOption...) should use sendfile on Linux
  • cee4f1d: 8203925: tools/javac/importscope/T8193717.java ran out of java heap
  • 694e1cd: 8262060: compiler/whitebox/BlockingCompilation.java timed out
  • 6946d91: 8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF
  • 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
  • ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • ... and 148 more: https://git.openjdk.java.net/jdk/compare/c3abdc9aadc734053dbcc43d5294d5f16a0b0ce3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 16, 2021
@dekonoplyov
Copy link
Author

@dekonoplyov dekonoplyov commented Apr 16, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dekonoplyov
Your change (at version 8cc9463) is now ready to be sponsored by a Committer.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 17, 2021

/sponsor

@openjdk openjdk bot closed this Apr 17, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Apr 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2021

@jayathirthrao @dekonoplyov Since your change was applied there have been 165 commits pushed to the master branch:

  • ff49970: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
  • c108e7a: 8265154: vinserti128 operand mix up for KNL platforms
  • 2c4075c: 8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp
  • 888d80b: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
  • 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
  • 4413dbf: 8263395: Incorrect use of Objects.nonNull
  • 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.
  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • 79adc16: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 1c3fd46: 8265175: (fs) Files.copy(Path,Path,CopyOption...) should use sendfile on Linux
  • ... and 155 more: https://git.openjdk.java.net/jdk/compare/c3abdc9aadc734053dbcc43d5294d5f16a0b0ce3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 926e3bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
2 participants