Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253379: [windows] Several jpackage tests failed with error code 1638 #337

Closed
wants to merge 3 commits into from

Conversation

andyherrick
Copy link

@andyherrick andyherrick commented Sep 24, 2020

8253379: [windows] Several jpackage tests failed with error code 1638
two windows specific test fixes in WindowsHelper:
1.) do not test that the parent directory of a windows menu shortcut is empty after shortcut is uninstalled (there may be other shortcuts using that directory)
2.) do not programmatically install windows exe installers (since we have no way of programmatically uninstalling them)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253379: [windows] Several jpackage tests failed with error code 1638

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/337/head:pull/337
$ git checkout pull/337

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2020

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 24, 2020
@openjdk
Copy link

openjdk bot commented Sep 24, 2020

@andyherrick The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the core-libs label Sep 24, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2020

Webrevs

@sashamatveev
Copy link
Member

sashamatveev commented Sep 24, 2020

According to msiexec help, msiexec supports ProductCode for uninstall "/x | Package|ProductCode". Do you know if it would be possible to use such options?

@alexeysemenyukoracle
Copy link
Member

alexeysemenyukoracle commented Sep 24, 2020

Currently msi wrapper unconditionally adds "/i" on msiexec command line. So passing "/x" option to exe installer would not work.
I think we need to rework msi wrapper to only support one command line option - "--uninstall" instead of passing all command line parameters to nested msiexec invocation.

@andyherrick
Copy link
Author

andyherrick commented Oct 5, 2020

Currently msi wrapper unconditionally adds "/i" on msiexec command line. So passing "/x" option to exe installer would not work.
I think we need to rework msi wrapper to only support one command line option - "--uninstall" instead of passing all command line parameters to nested msiexec invocation.

yes - but until we have that implemented in the wrapper, shouldn't we disable in the tests installing what we can't unintall ?

@openjdk openjdk bot removed the rfr label Oct 7, 2020
@openjdk openjdk bot added the rfr label Oct 7, 2020
if (!exists) {
TKit.assertPathExists(shortcutPath.getParent(), false);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this is related to disabling of running exe installers?

@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253379: [windows] Several jpackage tests failed with error code 1638

Reviewed-by: asemenyuk, almatvee, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 263 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 9, 2020
@andyherrick
Copy link
Author

andyherrick commented Oct 9, 2020

/integrate

@openjdk openjdk bot closed this Oct 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 9, 2020
@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@andyherrick Since your change was applied there have been 263 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit be26972.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the JDK-8253379 branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants