8253379: [windows] Several jpackage tests failed with error code 1638 #337
Conversation
|
👋 Welcome back herrick! A progress list of the required criteria for merging this PR into |
|
@andyherrick The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
|
According to msiexec help, msiexec supports ProductCode for uninstall "/x | Package|ProductCode". Do you know if it would be possible to use such options? |
|
Currently msi wrapper unconditionally adds "/i" on msiexec command line. So passing "/x" option to exe installer would not work. |
yes - but until we have that implemented in the wrapper, shouldn't we disable in the tests installing what we can't unintall ? |
| if (!exists) { | ||
| TKit.assertPathExists(shortcutPath.getParent(), false); | ||
| } |
There was a problem hiding this comment.
How this is related to disabling of running exe installers?
|
@andyherrick This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 263 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
openjdk
bot
added
integrated
|
@andyherrick Since your change was applied there have been 263 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit be26972. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
8253379: [windows] Several jpackage tests failed with error code 1638
two windows specific test fixes in WindowsHelper:
1.) do not test that the parent directory of a windows menu shortcut is empty after shortcut is uninstalled (there may be other shortcuts using that directory)
2.) do not programmatically install windows exe installers (since we have no way of programmatically uninstalling them)
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/337/head:pull/337$ git checkout pull/337