Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out #3375

Closed
wants to merge 3 commits into from

Conversation

@coleenp
Copy link

@coleenp coleenp commented Apr 7, 2021

Added a flag so that thread 2 will notify thread 1 after it's waiting, and not before.
Ran 100x on macosx-x64-debug without timeout (actually ran original 100x without timeout also).
The test relies on one thread waiting at a place where another can find the class loading in progress. Alternate suggestions welcome.
Thanks!
Coleen


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3375/head:pull/3375
$ git checkout pull/3375

Update a local copy of the PR:
$ git checkout pull/3375
$ git pull https://git.openjdk.java.net/jdk pull/3375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3375

View PR using the GUI difftool:
$ git pr show -t 3375

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3375.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Changes look good. One question: does 'ready' need to be volatile ?

@lfoltan
lfoltan approved these changes Apr 7, 2021
Copy link
Member

@lfoltan lfoltan left a comment

LGTM.
Lois

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out

Reviewed-by: hseigel, lfoltan, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • ec599da: 8264633: Add missing logging to PlatformRecording#stop
  • e89542f: 8264352: AArch64: Optimize vector "not/andNot" for NEON and SVE
  • 016db40: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to
  • 78d1164: 8214455: Relocate CDS archived regions to the top of the G1 heap
  • 88eb291: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr
  • a863ab6: 8264551: Unexpected warning when jpackage creates an exe
  • 6e2b82a: 8264731: Introduce InstanceKlass::method_at_itable_or_null()
  • 22b20f8: 8264424: Support OopStorage bulk allocation
  • ab3be72: 8264863: Update JCov version to support JDK 17
  • 774e5ae: 8264742: member variable _monitor of MonitorLocker is redundant
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/a756d8d7ef01b2eb990b6e84bdb45aaa4a7a96b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 7, 2021
@coleenp
Copy link
Author

@coleenp coleenp commented Apr 7, 2021

Changes look good. One question: does 'ready' need to be volatile ?

I added volatile to ready.

Thanks Lois and Harold!

@hseigel
hseigel approved these changes Apr 7, 2021
Copy link
Member

@hseigel hseigel left a comment

LGTM!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Coleen,

The synchronization in this test is highly suspect, but your change certainly helps address one of the race conditions.

Thanks,
David

test/hotspot/jtreg/runtime/ParallelLoad/MyLoader.java Outdated Show resolved Hide resolved
@coleenp
Copy link
Author

@coleenp coleenp commented Apr 8, 2021

Hopefully the synchronization will be more reliable with this change. I'll watch for problems with this test.
Thanks for the reviews, Lois, Harold and David.
/integrate

@openjdk openjdk bot closed this Apr 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@coleenp Since your change was applied there have been 20 commits pushed to the master branch:

  • ec599da: 8264633: Add missing logging to PlatformRecording#stop
  • e89542f: 8264352: AArch64: Optimize vector "not/andNot" for NEON and SVE
  • 016db40: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to
  • 78d1164: 8214455: Relocate CDS archived regions to the top of the G1 heap
  • 88eb291: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr
  • a863ab6: 8264551: Unexpected warning when jpackage creates an exe
  • 6e2b82a: 8264731: Introduce InstanceKlass::method_at_itable_or_null()
  • 22b20f8: 8264424: Support OopStorage bulk allocation
  • ab3be72: 8264863: Update JCov version to support JDK 17
  • 774e5ae: 8264742: member variable _monitor of MonitorLocker is redundant
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/a756d8d7ef01b2eb990b6e84bdb45aaa4a7a96b3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 255afbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the coleenp:parallel-test branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants