Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264514: HexFormat implementation tweaks #3381

Closed
wants to merge 1 commit into from

Conversation

@rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Apr 7, 2021

(Changed to new branch in personal fork)

Please review these small tweaks.
For background information see 1

Greetings
Raffaello


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3381/head:pull/3381
$ git checkout pull/3381

Update a local copy of the PR:
$ git checkout pull/3381
$ git pull https://git.openjdk.java.net/jdk pull/3381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3381

View PR using the GUI difftool:
$ git pr show -t 3381

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3381.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

@rgiulietti
Copy link
Contributor Author

@rgiulietti rgiulietti commented Apr 8, 2021

Automatically started Windows x64 tier1 tests are still running after more than 24 hours...

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264514: HexFormat implementation tweaks

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 326 new commits pushed to the master branch:

  • 9e7c748: 8265700: Regularize throws clauses in BigDecimal
  • 7116321: 8254565: JFR: Incorrect verification of mirror events
  • f45d460: 8265017: runtime/HiddenClasses/StressHiddenClasses.java timed out on Win* OCI
  • 0136c89: 8265490: Unterminated string passed to FindClass() in hotspot test
  • 325edbc: 8265450: Merge PreservedMarksSet::restore code paths
  • b337f63: 8037397: RegEx pattern matching loses character class after intersection (&&) operator
  • 07a7510: 8200145: Conditional expression mistakenly treated as standalone
  • 41fc7dd: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable
  • 45c474a: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
  • 18ee419: 8198422: Test java/awt/font/StyledMetrics/BoldSpace.java is unstable
  • ... and 316 more: https://git.openjdk.java.net/jdk/compare/21e7402b04d835625521e7ba6f10c58cf708d276...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 21, 2021
@rgiulietti
Copy link
Contributor Author

@rgiulietti rgiulietti commented Apr 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@rgiulietti
Your change (at version 123f310) is now ready to be sponsored by a Committer.

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Apr 22, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@RogerRiggs @rgiulietti Since your change was applied there have been 334 commits pushed to the master branch:

  • e16d568: 8265218: trace_method_handle_stub fails to find calling frame on x86
  • 86bd44f: 8257831: Suspend with handshakes
  • 28af31d: 8263668: Update java.time to use instanceof pattern variable
  • a93d911: 8265607: Avoid decrementing when no Symbol was created in ~SignatureStream
  • aa29784: 8265332: gtest/LargePageGtests.java OOMEs on -XX:+UseSHM cases
  • 33b6378: 8265101: Remove unnecessary functions in os*.inline.hpp
  • 28c35ae: 8259288: Debug build failure with clang-10 due to -Wimplicit-int-float-conversion
  • ca6b1b4: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
  • 9e7c748: 8265700: Regularize throws clauses in BigDecimal
  • 7116321: 8254565: JFR: Incorrect verification of mirror events
  • ... and 324 more: https://git.openjdk.java.net/jdk/compare/21e7402b04d835625521e7ba6f10c58cf708d276...master

Your commit was automatically rebased without conflicts.

Pushed as commit fa82d47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rgiulietti rgiulietti deleted the rgiulietti:JDK-8264514 branch Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants