8261625: Add Elements.isAutomaticModule(ModuleElement)

[jddarcy]

Addition of a small convenience method, with a default implementation, to Elements.

Most of the change is testing infrastructure. The negative cases, such as named modules, are tested in the style of other annotation processing tests for Elements utilities.

An automatic module comes from a jar file, so an API reading from a jar file is needed. To avoid piping in the awkward plumbing needed to do that directly in the annotation processing tests, I updated an existing automatic modules test which uses the tool box facility. My additions to the tool box might not be the done in the most idiomatic style for that API; happy to have guidance on how to proceed better there.

Assuming this general approach is agreed to, I'll update the imports on AutomaticModules.java to condense the text of the annotation processor source.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261625: Add Elements.isAutomaticModule(ModuleElement)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer) ⚠️ Review applies to 5dab5c2
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3382/head:pull/3382
$ git checkout pull/3382

Update a local copy of the PR:
$ git checkout pull/3382
$ git pull https://git.openjdk.java.net/jdk pull/3382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3382

View PR using the GUI difftool:
$ git pr show -t 3382

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3382.diff

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (cea0aa16)
• 01: Full - Incremental (5dab5c2f)
• 00: Full (fdeadb26)

[jddarcy]

PS And the CSR should be reviewed as well:

https://bugs.openjdk.java.net/browse/JDK-8264865

Thanks.

[vicente-romero-oracle]

2006 can be removed

[jddarcy]

I copied a file from 2006 and then edited the result, hence I started with the 2006 year.

[vicente-romero-oracle]

/csr

[openjdk]

@vicente-romero-oracle this pull request will not be integrated until the CSR request JDK-8264865 for issue JDK-8261625 has been approved.

[vicente-romero-oracle]

lgtm

[lahodaj]

LGTM

[jddarcy]

/integrate

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261625: Add `Elements.isAutomaticModule(ModuleElement)`

Reviewed-by: vromero, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 5bd6c74: 8236127: Use value of --icon CLI option to set icon for exe installers
• 81d35e4: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop.
• 04fa1ed: 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch
• 214d6e2: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable
• af13c64: 8264711: More runtime TRAPS cleanups
• 3aec2d9: 8264718: Shenandoah: enable string deduplication during root scanning
• 255afbe: 8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out
• ec599da: 8264633: Add missing logging to PlatformRecording#stop
• e89542f: 8264352: AArch64: Optimize vector "not/andNot" for NEON and SVE
• 016db40: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/6e2b82a45f2f86c45fe62dcc6cf5cb979b8a5366...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jddarcy Since your change was applied there have been 15 commits pushed to the master branch:

• 8a23580: 8264428: Cleanup usages of StringBuffer in java.desktop
• 308f679: 8264454: Jaxp unit test from open jdk needs to be improved
• 5bd6c74: 8236127: Use value of --icon CLI option to set icon for exe installers
• 81d35e4: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop.
• 04fa1ed: 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch
• 214d6e2: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable
• af13c64: 8264711: More runtime TRAPS cleanups
• 3aec2d9: 8264718: Shenandoah: enable string deduplication during root scanning
• 255afbe: 8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out
• ec599da: 8264633: Add missing logging to PlatformRecording#stop
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/6e2b82a45f2f86c45fe62dcc6cf5cb979b8a5366...master

Your commit was automatically rebased without conflicts.

Pushed as commit ccefa5e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.