Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp #3385

Closed
wants to merge 5 commits into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Apr 7, 2021

Miscellaneous cleanups in dependencies.cpp.

Testing:

  • hs-tier1 - hs-tier4

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3385/head:pull/3385
$ git checkout pull/3385

Update a local copy of the PR:
$ git checkout pull/3385
$ git pull https://git.openjdk.java.net/jdk pull/3385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3385

View PR using the GUI difftool:
$ git pr show -t 3385

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3385.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@iwanowww The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@iwanowww iwanowww changed the title Dependencies: Miscellaneous cleanups in dependencies.cpp 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp Apr 7, 2021
@iwanowww iwanowww marked this pull request as ready for review Apr 7, 2021
@openjdk openjdk bot added the rfr label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

Loading

Copy link
Contributor

@neliasso neliasso left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Reviewed-by: neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • f7a6c63: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
  • a45733f: 8264779: Fix doclint warnings in java/nio
  • 3e57924: 8264885: Fix the code style of macro in aarch64_neon_ad.m4
  • 051c117: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo
  • 1c6b113: 8264513: Cleanup CardTableBarrierSetC2::post_barrier
  • 666fd62: 8264881: Remove the old development option MemProfiling
  • 951f277: 8264874: Build interim-langtools for HotSpot only if Graal is enabled
  • 719f95e: 8260693: Provide the support for specifying a signer in keytool -genkeypair
  • 77b1673: 8256245: AArch64: Implement Base64 decoding intrinsic
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/6e2b82a45f2f86c45fe62dcc6cf5cb979b8a5366...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 9, 2021
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 9, 2021

Thanks for the review, Nils.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 9, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@iwanowww Since your change was applied there have been 38 commits pushed to the master branch:

  • 863feab: 8005295: Use mandated information for printing of repeating annotations
  • f26cd2a: 8264997: Remove SystemDictionary::cache_get
  • 9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
  • ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report
  • cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
  • 6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
  • 1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
  • 06e6b1f: 8259242: Remove ProtectionDomainSet_lock
  • 9bb1863: 8260923: Add more tests for SSLSocket input/output shutdown
  • 33fa855: 8264732: Clean up LinkResolver::vtable_index_of_interface_method()
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/6e2b82a45f2f86c45fe62dcc6cf5cb979b8a5366...master

Your commit was automatically rebased without conflicts.

Pushed as commit 07c8ff4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants