-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8264872: Dependencies: Migrate to PerfData counters #3386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into |
|
/label add hotspot-compiler-dev |
|
@iwanowww |
Webrevs
|
vnkozlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
neliasso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@iwanowww This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the reviews, Vladimir and Nils. |
|
/integrate |
Migrate performance counters on
Dependencies(deps_find_witness_*) toPerfData.Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3386/head:pull/3386$ git checkout pull/3386Update a local copy of the PR:
$ git checkout pull/3386$ git pull https://git.openjdk.java.net/jdk pull/3386/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3386View PR using the GUI difftool:
$ git pr show -t 3386Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3386.diff