Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264872: Dependencies: Migrate to PerfData counters #3386

Closed
wants to merge 10 commits into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Apr 7, 2021

Migrate performance counters on Dependencies (deps_find_witness_*) to PerfData.

Testing:

  • hs-tier1 - hs-tier2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264872: Dependencies: Migrate to PerfData counters

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3386/head:pull/3386
$ git checkout pull/3386

Update a local copy of the PR:
$ git checkout pull/3386
$ git pull https://git.openjdk.java.net/jdk pull/3386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3386

View PR using the GUI difftool:
$ git pr show -t 3386

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3386.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into pr/3385 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@iwanowww iwanowww changed the title 8264872.perf counters 8264872: Dependencies: Migrate to PerfData counters Apr 7, 2021
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 7, 2021

/label add hotspot-compiler-dev

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@iwanowww
The hotspot-compiler label was successfully added.

Loading

@iwanowww iwanowww marked this pull request as ready for review Apr 7, 2021
@openjdk openjdk bot added the rfr label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Loading

Copy link
Contributor

@neliasso neliasso left a comment

Looks good.

Loading

src/hotspot/share/code/dependencies.cpp Outdated Show resolved Hide resolved
Loading
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3385 to master Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264872: Dependencies: Migrate to PerfData counters

Reviewed-by: kvn, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 9, 2021
@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 9, 2021

Thanks for the reviews, Vladimir and Nils.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 9, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@iwanowww Pushed as commit 76bd313.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants