Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264873: Dependencies: Split ClassHierarchyWalker #3387

Closed
wants to merge 15 commits into from

Conversation

@iwanowww
Copy link

@iwanowww iwanowww commented Apr 7, 2021

Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder.

Testing:

  • hs-tier1 - hs-tier4

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264873: Dependencies: Split ClassHierarchyWalker

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3387/head:pull/3387
$ git checkout pull/3387

Update a local copy of the PR:
$ git checkout pull/3387
$ git pull https://git.openjdk.java.net/jdk pull/3387/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3387

View PR using the GUI difftool:
$ git pr show -t 3387

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3387.diff

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 7, 2021

/label add hotspot-compiler-dev

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into pr/3386 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@iwanowww
The hotspot-compiler label was successfully added.

Loading

@iwanowww iwanowww marked this pull request as ready for review Apr 7, 2021
@openjdk openjdk bot added the rfr label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

Loading

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3386 to master Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@iwanowww this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8264873.cha.split
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264873: Dependencies: Split ClassHierarchyWalker

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi
  • 5634f20: 8265932: Move safepoint related fields from class Thread to JavaThread
  • b67b2b1: 8265690: Use the latest Ubuntu base image version in Docker testing
  • b2628d1: 8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value()
  • 377b346: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added ready and removed merge-conflict labels Apr 9, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 27, 2021

Thanks for the reviews, Vladimir and Tobias.

Loading

@iwanowww
Copy link
Author

@iwanowww iwanowww commented Apr 27, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@iwanowww Since your change was applied there have been 6 commits pushed to the master branch:

  • 0a88f0a: 8255915: jdk/incubator/vector/AddTest.java timed out
  • ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi
  • 5634f20: 8265932: Move safepoint related fields from class Thread to JavaThread
  • b67b2b1: 8265690: Use the latest Ubuntu base image version in Docker testing
  • b2628d1: 8263972: C2: LoadVector/StoreVector type mismatch in MemNode::can_see_stored_value()
  • 377b346: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

Your commit was automatically rebased without conflicts.

Pushed as commit f560b89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants