8264874: Build interim-langtools for HotSpot only if Graal is enabled

[iklam]

Many HotSpot developers make only the hotspot target, and copy the resulting libjvm.so into an already-build JDK image.

HotSpot requires interim-langtools only when Graal is enabled. When Graal is disabled, we can avoid building interim-langtools. This improves the build time of make hotspot by about 20 seconds, or about 15%:

Old:
$ make clean
$ time make hotspot
....
real 1m57.905s
user 42m22.524s
sys 3m7.372s

New:
$ make clean
$ time make hotspot
....
real 1m39.916s
user 41m59.984s
sys 3m3.188s

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264874: Build interim-langtools for HotSpot only if Graal is enabled

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3389/head:pull/3389
$ git checkout pull/3389

Update a local copy of the PR:
$ git checkout pull/3389
$ git pull https://git.openjdk.java.net/jdk pull/3389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3389

View PR using the GUI difftool:
$ git pr show -t 3389

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3389.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (109addeb)

[vnkozlov]

Good.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264874: Build interim-langtools for HotSpot only if Graal is enabled

Reviewed-by: kvn, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• af13c64: 8264711: More runtime TRAPS cleanups
• 3aec2d9: 8264718: Shenandoah: enable string deduplication during root scanning
• 255afbe: 8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out
• ec599da: 8264633: Add missing logging to PlatformRecording#stop
• e89542f: 8264352: AArch64: Optimize vector "not/andNot" for NEON and SVE
• 016db40: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to
• 78d1164: 8214455: Relocate CDS archived regions to the top of the G1 heap
• 88eb291: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr
• a863ab6: 8264551: Unexpected warning when jpackage creates an exe

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

Thanks @vnkozlov and @erikj79 for the review!
/integrate

[openjdk]

@iklam Since your change was applied there have been 20 commits pushed to the master branch:

• 719f95e: 8260693: Provide the support for specifying a signer in keytool -genkeypair
• 77b1673: 8256245: AArch64: Implement Base64 decoding intrinsic
• 57f1e7d: 8264696: Multi-catch clause causes compiler exception because it uses the package-private supertype
• 3d2b4cc: 8264864: Multiple byte tag not supported by ASN.1 encoding
• ccefa5e: 8261625: Add Elements.isAutomaticModule(ModuleElement)
• 8a23580: 8264428: Cleanup usages of StringBuffer in java.desktop
• 308f679: 8264454: Jaxp unit test from open jdk needs to be improved
• 5bd6c74: 8236127: Use value of --icon CLI option to set icon for exe installers
• 81d35e4: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop.
• 04fa1ed: 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/6e2b82a45f2f86c45fe62dcc6cf5cb979b8a5366...master

Your commit was automatically rebased without conflicts.

Pushed as commit 951f277.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.