Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258788: incorrect response to change in window insets [lanai] #3390

Closed
wants to merge 1 commit into from

Conversation

@avu
Copy link

@avu avu commented Apr 7, 2021

Perform replaceSurfaceData on insets change


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258788: incorrect response to change in window insets [lanai]

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3390/head:pull/3390
$ git checkout pull/3390

Update a local copy of the PR:
$ git checkout pull/3390
$ git pull https://git.openjdk.java.net/jdk pull/3390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3390

View PR using the GUI difftool:
$ git pr show -t 3390

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3390.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@avu The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

Perform replaceSurfaceData on insets change
@avu avu force-pushed the JDK-8258788 branch from e63c3eb to 0aa7ca9 Apr 9, 2021
mrserb
mrserb approved these changes Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258788: incorrect response to change in window insets [lanai]

Reviewed-by: serb, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

  • e604320: 8264783: G1 BOT verification should not verify beyond allocation threshold
  • cb2806d: 8265018: [AIX] FileDispatcherImpl.c:31:10: fatal error: 'sys/mount.h' file not found
  • ecef1fc: 8264972: Unused TypeFunc declared in OptoRuntime
  • 440c34a: 8264644: Add PrintClassLoaderDataGraphAtExit to print the detailed CLD graph
  • b1ebf82: 8264358: Don't create invalid oop in method handle tracing
  • 627ad9f: 8262328: Templatize JVMFlag boilerplate access methods
  • c15680e: 8264868: Reduce inclusion of registerMap.hpp and register.hpp
  • 5784f6b: 8264948: Check for TLS extensions total length
  • 42f4d70: 8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB
  • 76bd313: 8264872: Dependencies: Migrate to PerfData counters
  • ... and 108 more: https://git.openjdk.java.net/jdk/compare/80681b547090d4ab2b43662312e63a6a210c070b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 9, 2021
@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 10, 2021

@avu I am running CI tests, please wait until EOD for integration.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 10, 2021

CI tests are fine. LGTM.

@avu
Copy link
Author

@avu avu commented Apr 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@avu
Your change (at version 0aa7ca9) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

@prrace prrace commented Apr 12, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@prrace @avu Since your change was applied there have been 126 commits pushed to the master branch:

  • f479437: 8265082: test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java fails validate-source
  • 27f4b27: 8264623: Change to Xcode 12.4 for building on Macos at Oracle
  • 7c20d97: 8265052: Break circular include dependency in objArrayOop.inline.hpp
  • b90ad76: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos
  • 125184e: 8265012: Shenandoah: Backout JDK-8264718
  • be0d46c: 8262068: Improve G1 Full GC by skipping compaction for regions with high survival ratio
  • f71be8b: 8264954: unified handling for VectorMask object re-materialization during de-optimization
  • 3c9858d: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded
  • e604320: 8264783: G1 BOT verification should not verify beyond allocation threshold
  • cb2806d: 8265018: [AIX] FileDispatcherImpl.c:31:10: fatal error: 'sys/mount.h' file not found
  • ... and 116 more: https://git.openjdk.java.net/jdk/compare/80681b547090d4ab2b43662312e63a6a210c070b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 714ae54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants