Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264881: Remove the old development option MemProfiling #3393

Closed
wants to merge 1 commit into from

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Apr 8, 2021

MemProfiler is a very old development option added at:

^As 00018/00000/00000
^Ad D 1.1 98/04/14 13:18:32 renes 1 0
^Ac date and time created 98/04/14 13:18:32 by renes
^Ae

Today it doesn't work because it is untested and there is no reason/scenario to prove it is useful.

After a short discussion in #3340, I'd like to propose removing the memprofiler if there are no strong objections.

Thanks!
Yang


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264881: Remove the old development option MemProfiling

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3393/head:pull/3393
$ git checkout pull/3393

Update a local copy of the PR:
$ git checkout pull/3393
$ git pull https://git.openjdk.java.net/jdk pull/3393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3393

View PR using the GUI difftool:
$ git pr show -t 3393

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3393.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 8, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 8, 2021

/label add hotspot-runtime
/label add hotspot

@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@kelthuzadx
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot label Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@kelthuzadx
The hotspot label was successfully added.

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 8, 2021

Gentle query: I do find another three product options(UseNewCode\d) that do nothing, they have been added in JDK6 as initial load commit(Maybe early). Does anyone know what's the intention of adding these options? Is it reasonable to remove them now?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2021

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

On 8/04/2021 1:51 pm, Yi Yang wrote:

On Thu, 8 Apr 2021 03:19:21 GMT, Yi Yang <yyang at openjdk.org> wrote:

MemProfiler is a very old development option added at:

^As 00018/00000/00000
^Ad D 1.1 98/04/14 13:18:32 renes 1 0
^Ac date and time created 98/04/14 13:18:32 by renes
^Ae

Today it doesn't work because it is untested and there is no reason/scenario to prove it is useful.

After a short discussion in https://github.com//pull/3340, I'd like to propose removing the memprofiler if there are no strong objections.

Thanks!
Yang

Gentle query: I do find another three product options(UseNewCode\d) that do nothing, they have been added in JDK6 as initial load commit(Maybe early). Does anyone know what's the intention of adding these options? Is it reasonable to remove them now?

The UseNewCode flags are there as a development aid so that you can
conditionally enable changed logic during development without needing to
add a new runtime flag just for that. It can be very useful for gating
changes when doing performance runs. No code ever gets committed that
actually uses them though.

So no, please do not delete them. :)

Thanks,
David

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Yi,

Actual code removal looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264881: Remove the old development option MemProfiling

Reviewed-by: dholmes, coleenp, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 951f277: 8264874: Build interim-langtools for HotSpot only if Graal is enabled
  • 719f95e: 8260693: Provide the support for specifying a signer in keytool -genkeypair
  • 77b1673: 8256245: AArch64: Implement Base64 decoding intrinsic
  • 57f1e7d: 8264696: Multi-catch clause causes compiler exception because it uses the package-private supertype
  • 3d2b4cc: 8264864: Multiple byte tag not supported by ASN.1 encoding
  • ccefa5e: 8261625: Add Elements.isAutomaticModule(ModuleElement)
  • 8a23580: 8264428: Cleanup usages of StringBuffer in java.desktop
  • 308f679: 8264454: Jaxp unit test from open jdk needs to be improved
  • 5bd6c74: 8236127: Use value of --icon CLI option to set icon for exe installers
  • 81d35e4: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop.
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/c3abdc9aadc734053dbcc43d5294d5f16a0b0ce3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @coleenp, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 8, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 8, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

On 8/04/2021 1:51 pm, Yi Yang wrote:

On Thu, 8 Apr 2021 03:19:21 GMT, Yi Yang wrote:

MemProfiler is a very old development option added at:
^As 00018/00000/00000
^Ad D 1.1 98/04/14 13:18:32 renes 1 0
^Ac date and time created 98/04/14 13:18:32 by renes
^Ae
Today it doesn't work because it is untested and there is no reason/scenario to prove it is useful.
After a short discussion in https://github.com/[/pull/3340](https://github.com/openjdk/jdk/pull/3340), I'd like to propose removing the memprofiler if there are no strong objections.
Thanks!
Yang

Gentle query: I do find another three product options(UseNewCode\d) that do nothing, they have been added in JDK6 as initial load commit(Maybe early). Does anyone know what's the intention of adding these options? Is it reasonable to remove them now?

The UseNewCode flags are there as a development aid so that you can
conditionally enable changed logic during development without needing to
add a new runtime flag just for that. It can be very useful for gating
changes when doing performance runs. No code ever gets committed that
actually uses them though.

So no, please do not delete them. :)

Thanks,
David

Got it. Thank you David, you are the OpenJDK encyclopedia. :)
(PS: it looks like they are wrongly marked as product flags)

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

On 8/04/2021 4:04 pm, Yi Yang wrote:

On Thu, 8 Apr 2021 05:38:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

The UseNewCode flags are there as a development aid so that you can
conditionally enable changed logic during development without needing to
add a new runtime flag just for that. It can be very useful for gating
changes when doing performance runs. No code ever gets committed that
actually uses them though.

So no, please do not delete them. :)

Thanks,
David

Got it. Thank you David, you are the OpenJDK encyclopedia. :)
(PS: it looks like they are wrongly marked as product flags)

No that is deliberate as well. Lets say I'm doing a performance test on
two variants of a fix. I use UseNewCode to select between them, but I
want to do the performance run on a product build.

Cheers,
David

@coleenp
coleenp approved these changes Apr 8, 2021
Copy link

@coleenp coleenp left a comment

Thank you for finding and removing this code.

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 9, 2021

Thanks @dholmes-ora @coleenp for the review.

/integrate

@openjdk openjdk bot added the sponsor label Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@kelthuzadx
Your change (at version 4ab648b) is now ready to be sponsored by a Committer.

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine to me as well.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 9, 2021

/sponsor

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@shipilev @kelthuzadx Since your change was applied there have been 32 commits pushed to the master branch:

  • 951f277: 8264874: Build interim-langtools for HotSpot only if Graal is enabled
  • 719f95e: 8260693: Provide the support for specifying a signer in keytool -genkeypair
  • 77b1673: 8256245: AArch64: Implement Base64 decoding intrinsic
  • 57f1e7d: 8264696: Multi-catch clause causes compiler exception because it uses the package-private supertype
  • 3d2b4cc: 8264864: Multiple byte tag not supported by ASN.1 encoding
  • ccefa5e: 8261625: Add Elements.isAutomaticModule(ModuleElement)
  • 8a23580: 8264428: Cleanup usages of StringBuffer in java.desktop
  • 308f679: 8264454: Jaxp unit test from open jdk needs to be improved
  • 5bd6c74: 8236127: Use value of --icon CLI option to set icon for exe installers
  • 81d35e4: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop.
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/c3abdc9aadc734053dbcc43d5294d5f16a0b0ce3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 666fd62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kelthuzadx kelthuzadx deleted the kelthuzadx:cleanup_memprofile branch Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants