Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253606: Need to add missed constructor to the SwingEventMonitor #340

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 24, 2020

The javadoc for the constructor in this class was added, but the constructor itsef is missed......


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253606: Need to add missed constructor to the SwingEventMonitor

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/340/head:pull/340
$ git checkout pull/340

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@mrserb The following labels will be automatically applied to this pull request: 2d core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2020

Webrevs

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 24, 2020

/csr

Loading

@openjdk openjdk bot added the csr label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@mrserb this pull request will not be integrated until the CSR request JDK-8253609 for issue JDK-8253606 has been approved.

Loading

@prrace
Copy link
Contributor

@prrace prrace commented Sep 24, 2020

/label add swing

Loading

@prrace
Copy link
Contributor

@prrace prrace commented Sep 24, 2020

/label remove core-libs

Loading

@prrace
Copy link
Contributor

@prrace prrace commented Sep 24, 2020

/label remove 2d

Loading

@openjdk openjdk bot added the swing label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@prrace
The swing label was successfully added.

Loading

@openjdk openjdk bot removed the core-libs label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@prrace
The core-libs label was successfully removed.

Loading

@openjdk openjdk bot removed the 2d label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@prrace
The 2d label was successfully removed.

Loading

prrace
prrace approved these changes Oct 1, 2020
@openjdk openjdk bot removed the csr label Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253606: Need to add missed constructor to the SwingEventMonitor

Reviewed-by: jdv, pbansal, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 125 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 2, 2020
@prrace
Copy link
Contributor

@prrace prrace commented Oct 2, 2020

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@prrace Only the author (@mrserb) is allowed to issue the integrate command.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 2, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 2, 2020
@openjdk openjdk bot added the integrated label Oct 2, 2020
@openjdk openjdk bot removed ready rfr labels Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@mrserb Since your change was applied there have been 126 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit d296708.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mrserb mrserb deleted the JDK-8253606 branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants