Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor #3406

Closed
wants to merge 5 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 9, 2021

This testcase was a regression testcase for a windows bug JDK-6242241 whereby dragging an attachment from a Microsoft Outlook message to the application results in blank or semicolons.
The testcase was later made applicable to windows only by JDK-7147083
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/d8efcad28072
so we can remove the test from Problemlist which is problemlisted for linux and mac.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3406/head:pull/3406
$ git checkout pull/3406

Update a local copy of the PR:
$ git checkout pull/3406
$ git pull https://git.openjdk.java.net/jdk pull/3406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3406

View PR using the GUI difftool:
$ git pr show -t 3406

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3406.diff

…/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 9, 2021
@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 9, 2021

/label add awt

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Apr 9, 2021
@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@prsadhuk
The awt label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 9, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 365 new commits pushed to the master branch:

  • 27dd88b: 8262957: (fs) Fail fast in UnixFileStore.isExtendedAttributesEnabled
  • e2106d5: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0
  • ebbce91: 8264681: Use the blessed modifier order in java.security
  • ea5c55a: 8265103: Remove unnecessary inclusion of oopMap.hpp
  • 26186ec: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
  • 283d64f: 8262896: [macos_aarch64] Crash in jni_fast_GetLongField
  • 55d5649: 8263157: [macos]: java.library.path is being set incorrectly
  • e80012e: 8264768: JFR: Allow events to be printed to the log
  • 3b576ed: 8265100: (fs) WindowsFileStore.hashCode() should read cached hash code once
  • 8df8512: 8265125: IGV: cannot edit forms with NetBeans GUI builder
  • ... and 355 more: https://git.openjdk.java.net/jdk/compare/d24e4cfef36026b781906a9e0c5cf519eb72696e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 9, 2021
Copy link
Member

@mrserb mrserb left a comment

The bug was added to the problem list by the JDK-8255365, because SQE reported it on Ubuntu in jdk15. This looks strange since the tag "@requires" was added in jdk9.

BTW the bug filed JDK-8080185 is unrelated to the macOS and Linux, it is about removing the outlook requirement for test execution on windows(this may allow it to be run on other platforms)

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 9, 2021

This test in its current position is not supposed to (or will not run) in non-windows platform as we have @requires tag... Probably SQE is running some old test.
Also, the regression test was added specially for Microsoft Outlook drag issue so I don't think we should use some other requirement just to make it pass for other platform or even on windows.

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Apr 9, 2021

We were missing @requires tag in the html file because of which it was being executed in non-wndows platform.

test/jdk/ProblemList.txt Show resolved Hide resolved
"1. Start MS Outlook program. Find and open ",
" the mail form with attachments.",
"2. Select attachments from the mail and drag into a red field of applet.",
"1. Select any file from File Explorer and drag into a red field of applet.",
Copy link
Member

@mrserb mrserb Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that "any file from File Explorer" can reproduce the initial JDK-6242241 bug?

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will work fine as initial JDK-6242241 bug says "It works fine when dragging from Windows Explorer" but you told to remove Outlook requirement. The JDK-6242241 bug is specifically Outlook issue so that's why I told "regression test was added specially for Microsoft Outlook drag issues"

Copy link
Member

@mrserb mrserb Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug was filed to remove the "Outlook requirement" but it does not mean that we should lose the opportunity to verify the JDK-6242241.

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I am understanding..
JDK-6242241 was Outlook bug so I am not sure how to remove "Outlook requirement" to verify that fix and thus bug? I don't think we can satisfy both requirement!!!
Are you saying we will add @requires but not remove from problem list?
Or add
Outlook steps plus
"If Outlook is not present in some platform then you can test with any file from File Explorer"

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think the bug was raised by internal SQE when it was thought that the test could be run on multiple platforms but
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/d8efcad28072
made sure it can be run only for windows (although fix not done fully). So, I think we should just add @requires in the html file and not put much stress on removing Outlook requirement.

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more comments on this? I tried removing "Outlook requirement" but couldn't so reinstated back based on the above comments.

Copy link
Member

@mrserb mrserb Apr 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to try some possibilities to remove the "Outlook requirement" and at the same time cover the verification of the JDK-6242241. So yes we need to have both. We probably can create the native app from which the user should be able to drag the data, or we may try to run two java processes, etc to emulate the DnD from the Outlook.

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2021

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@prsadhuk prsadhuk closed this May 15, 2021
@prsadhuk prsadhuk deleted the 8080185 branch May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants